Zhou Zheng Sheng has uploaded a new change for review.
Change subject: Add genisoimage to rpm dependencies ......................................................................
Add genisoimage to rpm dependencies
vdsm/mkimage.py is using mkisofs, this command is provided by genisoimage.
Change-Id: I67d33637982f08e8545a8e5ad8b3fd719ccfec5b Signed-off-by: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com --- M vdsm.spec.in 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/32/7232/1
diff --git a/vdsm.spec.in b/vdsm.spec.in index 23afd6b..ae03091 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -84,6 +84,7 @@ Requires: tree Requires: dosfstools Requires: policycoreutils-python +Requires: genisoimage Requires(pre,preun): policycoreutils-python Requires: libselinux-python Requires: %{name}-python = %{version}-%{release}
-- To view, visit http://gerrit.ovirt.org/7232 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I67d33637982f08e8545a8e5ad8b3fd719ccfec5b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add genisoimage to rpm dependencies ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/470/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/7232 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I67d33637982f08e8545a8e5ad8b3fd719ccfec5b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Zhou Zheng Sheng has posted comments on this change.
Change subject: Add genisoimage to rpm dependencies ......................................................................
Patch Set 1:
Recently I am trying to do some functional tests, so setup a new machine and discover a missing dependency for vdsm rpm spec.
-- To view, visit http://gerrit.ovirt.org/7232 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I67d33637982f08e8545a8e5ad8b3fd719ccfec5b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Mark Wu has posted comments on this change.
Change subject: Add genisoimage to rpm dependencies ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/7232 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I67d33637982f08e8545a8e5ad8b3fd719ccfec5b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Add genisoimage to rpm dependencies ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
nice!
-- To view, visit http://gerrit.ovirt.org/7232 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I67d33637982f08e8545a8e5ad8b3fd719ccfec5b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Zhou Zheng Sheng has posted comments on this change.
Change subject: Add genisoimage to rpm dependencies ......................................................................
Patch Set 1: Verified
Run through autobuild.sh. Then I "yum localinstall" the generated rpm in a fresh machine, then genisoimage dependency is resolved by yum and download and installed.
-- To view, visit http://gerrit.ovirt.org/7232 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I67d33637982f08e8545a8e5ad8b3fd719ccfec5b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: Add genisoimage to rpm dependencies ......................................................................
Patch Set 1: Looks good to me, approved
Thanks.
-- To view, visit http://gerrit.ovirt.org/7232 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I67d33637982f08e8545a8e5ad8b3fd719ccfec5b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Add genisoimage to rpm dependencies ......................................................................
Add genisoimage to rpm dependencies
vdsm/mkimage.py is using mkisofs, this command is provided by genisoimage.
Change-Id: I67d33637982f08e8545a8e5ad8b3fd719ccfec5b Signed-off-by: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com --- M vdsm.spec.in 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: Douglas Schilling Landgraf: Looks good to me, but someone else must approve Mark Wu: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Zhou Zheng Sheng: Verified
-- To view, visit http://gerrit.ovirt.org/7232 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I67d33637982f08e8545a8e5ad8b3fd719ccfec5b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org