From Dan Kenigsberg danken@redhat.com:
Dan Kenigsberg has posted comments on this change.
Change subject: tests: Avoid global state modification using forked ......................................................................
Patch Set 1: -Code-Review
(1 comment)
https://gerrit.ovirt.org/#/c/67338/1/tests/moduleloader_test.py File tests/moduleloader_test.py:
Line 39: for f in files: Line 40: utils.touchFile(os.path.join(path, f)) Line 41: utils.touchFile(os.path.join(path, '__init__.py')) Line 42: sys.path.append(os.path.dirname(path)) Line 43: yield importlib.import_module(os.path.basename(path))
You don't need to monkey patch if you run in another process, this is compl
Do you suggest to run all tests (everywhere, not just this module) in a subprocess? Line 44: Line 45: @permutations( Line 46: [(('a.py', 'b.py'), ('a', 'b')), Line 47: (('a.py', 'b.py', 'a.pyc', 'a.pyioas'), ('a', 'b')),
vdsm-patches@lists.fedorahosted.org