Antoni Segura Puimedon has posted comments on this change.
Change subject: Update except syntax according to pep3110.
......................................................................
Patch Set 2: Verified
Added a lot of missing ones in the form of:
except blah.foo, moo:
Removed unused assignments of exceptions as per Ewoud's suggestion.
antoni@nx01 ~/code/vdsm> gitpydiff
checking contrib/nfs-check.py
checking tests/apiTests.py
checking tests/miscTests.py
checking vds_bootstrap/vds_bootstrap.py
checking vdsm/API.py
checking vdsm/BindingXMLRPC.py
checking vdsm/caps.py
checking vdsm/clientIF.py
checking vdsm/configNetwork.py
checking vdsm/gluster/cli.py
checking vdsm/kaxmlrpclib.py
checking vdsm/libvirtconnection.py
checking vdsm/libvirtvm.py
checking vdsm/mkimage.py
checking vdsm/netinfo.py
checking vdsm/storage/blockSD.py
checking vdsm/storage/blockVolume.py
checking vdsm/storage/dispatcher.py
checking vdsm/storage/domainMonitor.py
checking vdsm/storage/fileSD.py
checking vdsm/storage/fileUtils.py
checking vdsm/storage/fileVolume.py
checking vdsm/storage/hsm.py
checking vdsm/storage/image.py
2 difference(s)
first file: vdsm/storage/image.py
second file: /tmp/pydiff/vdsm/storage/image.py
((921, AssName('e', 'OP_ASSIGN')), ('921 + -', None))
((955, AssName('e', 'OP_ASSIGN')), ('955 + -', None))
checking vdsm/storage/imageRepository/formatConverter.py
checking vdsm/storage/lvm.py
checking vdsm/storage/misc.py
checking vdsm/storage/remoteFileHandler.py
2 difference(s)
first file: vdsm/storage/remoteFileHandler.py
second file: /tmp/pydiff/vdsm/storage/remoteFileHandler.py
((399, AssName('ex', 'OP_ASSIGN')), ('399 + -', None))
((405, AssName('ex', 'OP_ASSIGN')), ('405 + -', None))
checking vdsm/storage/resourceFactories.py
1 difference(s)
first file: vdsm/storage/resourceFactories.py
second file: /tmp/pydiff/vdsm/storage/resourceFactories.py
((179, AssName('e', 'OP_ASSIGN')), ('179 + -', None))
checking vdsm/storage/resourceManager.py
4 difference(s)
first file: vdsm/storage/resourceManager.py
second file: /tmp/pydiff/vdsm/storage/resourceManager.py
((824, AssName('ex', 'OP_ASSIGN')), ('824 + -', None))
((827, AssName('ex', 'OP_ASSIGN')), ('827 + -', None))
((872, AssName('ex', 'OP_ASSIGN')), ('872 + -', None))
((876, AssName('ex', 'OP_ASSIGN')), ('876 + -', None))
checking vdsm/storage/safelease.py
checking vdsm/storage/sp.py
1 difference(s)
first file: vdsm/storage/sp.py
second file: /tmp/pydiff/vdsm/storage/sp.py
((300, AssName('e', 'OP_ASSIGN')), ('300 + -', None))
checking vdsm/storage/storageServer.py
checking vdsm/storage/storage_mailbox.py
checking vdsm/storage/task.py
checking vdsm/storage/taskManager.py
checking vdsm/storage/volume.py
checking vdsm/supervdsm.py
checking vdsm/supervdsmServer.py
checking vdsm/tc.py
checking vdsm/utils.py
checking vdsm/vm.py
checking vdsm_api/BindingJsonRpc.py
checking vdsm_api/Bridge.py
checking vdsm_cli/vdsClient.py
checking vdsm_reg/createDaemon.py
checking vdsm_reg/deployUtil.py.in
checking vdsm_reg/register-to-engine.py
antoni@nx01 ~/code/vdsm>
--
To view, visit
http://gerrit.ovirt.org/10942
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c4ac78dace34a41e1afb9f6560889ad9bd34ddf
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server