Dan Kenigsberg has uploaded a new change for review.
Change subject: tcTests: test port-mirroring while another device is watching ......................................................................
tcTests: test port-mirroring while another device is watching
Change-Id: I06f654be269ccbbfc90dd29e30239eb010db3df8 Signed-off-by: Dan Kenigsberg danken@redhat.com --- M tests/tcTests.py 1 file changed, 21 insertions(+), 8 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/59/7459/1
diff --git a/tests/tcTests.py b/tests/tcTests.py index 9bbfcda..c60efff 100644 --- a/tests/tcTests.py +++ b/tests/tcTests.py @@ -43,12 +43,12 @@
class _Interface(): - def __init__(self): - self.devName = self._generateRandomBridgeName() + def __init__(self, prefix='vdsmtest-'): + self.devName = self._generateRandomName(prefix)
- def _generateRandomBridgeName(self): + def _generateRandomName(self, prefix): char_set = string.ascii_letters + string.digits - return 'vdsmtest-' + ''.join(random.sample(char_set, 5)) + return prefix + ''.join(random.sample(char_set, 5))
def _ifUp(self): check_call([EXT_IP, "link", "set", self.devName, "up"]) @@ -231,24 +231,31 @@
_tap0 = _Tap() _tap1 = _Tap() - _bridge0 = _Bridge() - _bridge1 = _Bridge() + _tap2 = _Tap() + _bridge0 = _Bridge('src-') + _bridge1 = _Bridge('target-') + _bridge2 = _Bridge('target2-')
@ValidateRunningAsRoot def setUp(self): _checkDependencies() self._tap0.addDevice() self._tap1.addDevice() + self._tap2.addDevice() self._bridge0.addDevice() self._bridge1.addDevice() + self._bridge2.addDevice() self._bridge0.addIf(self._tap0.devName) self._bridge1.addIf(self._tap1.devName) + self._bridge2.addIf(self._tap2.devName)
def tearDown(self): self._tap0.delDevice() self._tap1.delDevice() + self._tap2.delDevice() self._bridge0.delDevice() self._bridge1.delDevice() + self._bridge2.delDevice()
def _sendPing(self): self._tap1.startListener(self._ICMP) @@ -264,9 +271,15 @@
def testMirroring(self): tc.setPortMirroring(self._bridge0.devName, self._bridge1.devName) - self.assertTrue(self._sendPing(), " Bridge received no mirrored ping" + self.assertTrue(self._sendPing(), " Bridge received no mirrored ping " "requests.")
tc.unsetPortMirroring(self._bridge0.devName, self._bridge1.devName) - self.assertFalse(self._sendPing(), " Bridge received mirrored ping" + self.assertFalse(self._sendPing(), " Bridge received mirrored ping " "requests, but mirroring is unset.") + + def testMirroringWithDistraction(self): + "setting another mirror action should not obstract the first one" + tc.setPortMirroring(self._bridge0.devName, self._bridge2.devName) + self.testMirroring() + tc.unsetPortMirroring(self._bridge0.devName, self._bridge2.devName)
-- To view, visit http://gerrit.ovirt.org/7459 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I06f654be269ccbbfc90dd29e30239eb010db3df8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tcTests: test port-mirroring while another device is watching ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/661/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/7459 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I06f654be269ccbbfc90dd29e30239eb010db3df8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Antoni Segura Puimedon has posted comments on this change.
Change subject: tcTests: test port-mirroring while another device is watching ......................................................................
Patch Set 1: Verified; Looks good to me, but someone else must approve
I did previously the same test manually with tcpdump by console to test that all of this worked.
-- To view, visit http://gerrit.ovirt.org/7459 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I06f654be269ccbbfc90dd29e30239eb010db3df8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Antoni Segura Puimedon has posted comments on this change.
Change subject: tcTests: test port-mirroring while another device is watching ......................................................................
Patch Set 2: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/7459 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I06f654be269ccbbfc90dd29e30239eb010db3df8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Antoni Segura Puimedon has posted comments on this change.
Change subject: tcTests: test port-mirroring while another device is watching ......................................................................
Patch Set 3: Verified; Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/7459 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I06f654be269ccbbfc90dd29e30239eb010db3df8 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tcTests: test port-mirroring while another device is watching ......................................................................
Patch Set 3:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/720/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/7459 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I06f654be269ccbbfc90dd29e30239eb010db3df8 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Igor Lvovsky has posted comments on this change.
Change subject: tcTests: test port-mirroring while another device is watching ......................................................................
Patch Set 3: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/7459 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I06f654be269ccbbfc90dd29e30239eb010db3df8 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tcTests: test port-mirroring while another device is watching ......................................................................
tcTests: test port-mirroring while another device is watching
Change-Id: I06f654be269ccbbfc90dd29e30239eb010db3df8 Signed-off-by: Dan Kenigsberg danken@redhat.com --- M tests/tcTests.py 1 file changed, 21 insertions(+), 8 deletions(-)
Approvals: Antoni Segura Puimedon: Verified; Looks good to me, but someone else must approve Dan Kenigsberg: Igor Lvovsky: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/7459 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I06f654be269ccbbfc90dd29e30239eb010db3df8 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org