Francesco Romani has posted comments on this change.
Change subject: vm: do not call before_vm_start in dehibernation
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/45074/1//COMMIT_MSG
Commit Message:
Line 14: gonna be used in the dehibernation path. The hook is fed with
Line 15: phony data, and the output of the hook is discarded.
Line 16:
Line 17: This patch dispel the lie and avoid to call the before_vm_create
Line 18: hook in the dehibernation path.
this removal is problematic. We may have hooks that depend on this
call. vm
Good point. Will start checking myself and write down a list.
Btw, since the XML used as input is wrong, I wonder how the hooks which depend on that
actually work.
Line 19:
Line 20: Change-Id: I4c1377346b1ae63a1feb15e1458b5141c255c849
Line 21: X-Backport-To: 3.6
--
To view, visit
https://gerrit.ovirt.org/45074
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c1377346b1ae63a1feb15e1458b5141c255c849
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes