Dan Kenigsberg has posted comments on this change.
Change subject: vm: Set numatune and guest numa topology
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/25254/2/vdsm/vm.py
File vdsm/vm.py:
Line 1131: numa = XMLElement('numa')
Line 1132: guestNumaNodes = self.conf.get('guestNumaNodes')
Line 1133: for vmCell in guestNumaNodes:
Line 1134: numa.appendChildWithArgs('cell',
Line 1135:
cpus=vmCell['cpus'].replace(";", ","),
Would you explain why do we need this special handling of the semicolon? Why should we
accept both colon and semicolon for the same purpose? At the least, please document this
oddity in the commit message.
Line 1136: memory=str(vmCell['memory']))
Line 1137: cpu.appendChild(numa)
Line 1138:
Line 1139: self.dom.appendChild(cpu)
--
To view, visit
http://gerrit.ovirt.org/25254
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I88ec56047809b03449a788ead0b97f9ed876712d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi(a)hp.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi(a)hp.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes