Nir Soffer has uploaded a new change for review.
Change subject: procwatch: Move test helpers to bottom
......................................................................
procwatch: Move test helpers to bottom
The most important thing in a test class are the tests, not the helpers.
If you want to inspect the implementation details please scroll down.
Change-Id: Ib5909a0016b04d67cbdeec845234bcfcb61fbde7
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M tests/procwatch_test.py
1 file changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/75/65075/1
diff --git a/tests/procwatch_test.py b/tests/procwatch_test.py
index 1c6b365..49181f5 100644
--- a/tests/procwatch_test.py
+++ b/tests/procwatch_test.py
@@ -32,12 +32,6 @@
@expandPermutations
class ProcessWatcherTests(VdsmTestCase):
- def assertUnexpectedCall(self, data):
- raise AssertionError("Unexpected data: %r" % data)
-
- def startCommand(self, command):
- return compat.CPopen(command)
-
@permutations([
(['echo', '-n', '%s'], True, False),
(['sh', '-c', 'echo -n "%s" >&2'],
False, True),
@@ -130,3 +124,9 @@
retcode = c.wait()
self.assertEqual(retcode, expected_retcode)
+
+ def assertUnexpectedCall(self, data):
+ raise AssertionError("Unexpected data: %r" % data)
+
+ def startCommand(self, command):
+ return compat.CPopen(command)
--
To view, visit
https://gerrit.ovirt.org/65075
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib5909a0016b04d67cbdeec845234bcfcb61fbde7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>