ShaoHe Feng has posted comments on this change.
Change subject: vdsm: Refactoring libvirtvm & vm ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
just reviewed the first ten files.
.................................................... File vdsm/Makefile.am Line 58: vm/migration/__init__.py \ Line 59: vm/migration/downtime_thread.py \ Line 60: vm/migration/monitor_thread.py \ Line 61: vm/migration/source_thread.py \ Line 62: vm/notifying_domain.py \ vm/states.py missing? Line 63: vm/stats_thread.py \ Line 64: vm/vm.py \ Line 65: vmChannels.py \ Line 66: zombieReaper.py \
.................................................... File vdsm.spec.in Line 645: %{_datadir}/%{vdsm_name}/vm/migration/downtime_thread.py* Line 646: %{_datadir}/%{vdsm_name}/vm/migration/monitor_thread.py* Line 647: %{_datadir}/%{vdsm_name}/vm/migration/source_thread.py* Line 648: %{_datadir}/%{vdsm_name}/vm/notifying_domain.py* Line 649: %{_datadir}/%{vdsm_name}/vm/stats_thread.py* %{_datadir}/%{vdsm_name}/vm/states.py missing? Line 650: %{_datadir}/%{vdsm_name}/vm/vm.py* Line 651: %{_datadir}/%{vdsm_name}/vmChannels.py* Line 652: %{_datadir}/%{vdsm_name}/write-net-config Line 653: %{_datadir}/%{vdsm_name}/zombieReaper.py*
-- To view, visit http://gerrit.ovirt.org/10861 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I653be8e06431f1033416aa55d6cb81b4262ba6b1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org