Eduardo has uploaded a new change for review.
Change subject: Use more fine lock for hsm.deleteImage(). ......................................................................
Use more fine lock for hsm.deleteImage().
When removing an image from a specific SD, lock the image in this SD exclusively.
Related to: BZ#960952.
Change-Id: Iab04d548610cd86eb70e1fd13a29a3508778cc1d Signed-off-by: Eduardo ewarszaw@redhat.com --- M vdsm/storage/hsm.py 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/13/16413/1
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py index 5639c13..09c5404 100644 --- a/vdsm/storage/hsm.py +++ b/vdsm/storage/hsm.py @@ -1437,7 +1437,8 @@ self.getPool(spUUID) # Validates that the pool is connected. WHY? dom = self.validateSdUUID(sdUUID)
- vars.task.getExclusiveLock(STORAGE, imgUUID) + imageResourcesNamespace = sd.getNamespace(sdUUID, IMAGE_NAMESPACE) + vars.task.getExclusiveLock(imageResourcesNamespace, imgUUID) vars.task.getSharedLock(STORAGE, sdUUID) allVols = dom.getAllVolumes() volsByImg = sd.getVolsOfImage(allVols, imgUUID)
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Use more fine lock for hsm.deleteImage(). ......................................................................
Patch Set 1: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3065/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3144/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2252/ : FAILURE
Ayal Baron has posted comments on this change.
Change subject: Use more fine lock for hsm.deleteImage(). ......................................................................
Patch Set 1: Looks good to me, approved
Itamar Heim has posted comments on this change.
Change subject: Use more fine lock for hsm.deleteImage(). ......................................................................
Patch Set 1:
old. not touched for a while. please restore if relevant
Itamar Heim has abandoned this change.
Change subject: Use more fine lock for hsm.deleteImage(). ......................................................................
Abandoned
vdsm-patches@lists.fedorahosted.org