From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: hugepages: add support for shared pages
......................................................................
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/77808/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 426:
Line 427: @property
Line 428: def hugepages_shared(self):
Line 429: custom = self._custom['custom']
Line 430: hugepages_shared = conv.tobool(custom.get('hugepages_shared',
False))
a variable named just like its scope is very confusing. can you choose another name? this,
too, would be solved if the property is declared private as suggested by Francesco.
Line 431: return hugepages_shared
Line 432:
Line 433: def _get_lastStatus(self):
Line 434: # note that we don't use _statusLock here. One of the reasons is
the
--
To view, visit
https://gerrit.ovirt.org/77808
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0eb7b20a16e3e4a0d57da02ff7490136071dd8f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes