Yaniv Bronhaim has uploaded a new change for review.
Change subject: vdsm: generating uuid for libvirt configuration (#842115) ......................................................................
vdsm: generating uuid for libvirt configuration (#842115)
during migration we found that if both hosts as the same uuid libvirt fails the migration. this fix generate uniqe uuid only during vdsm reconfiguration. this uuid is saved in libvirtd.conf file and ha sbeen used after libvirt service are restarted.
Change-Id: I12478f64850dc3b3e421a562762c020819c8be28 Signed-off-by: Yaniv Bronhaim ybronhei@redhat.com --- M vdsm/vdsmd.init.in 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/32/7332/1
diff --git a/vdsm/vdsmd.init.in b/vdsm/vdsmd.init.in index efa6579..ee2b51a 100755 --- a/vdsm/vdsmd.init.in +++ b/vdsm/vdsmd.init.in @@ -347,6 +347,8 @@ set_if_default $lconf unix_sock_rw_perms "0770" set_if_default $lconf auth_unix_rw "sasl" set_if_default $qconf dynamic_ownership 0 + set_if_default $lconf host_uuid "$(uuidgen)" + if [[ "$ssl" == true ]]; then set_if_default $qconf spice_tls 1 else
-- To view, visit http://gerrit.ovirt.org/7332 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I12478f64850dc3b3e421a562762c020819c8be28 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: generating uuid for libvirt configuration (#842115) ......................................................................
Patch Set 1:
Build Failed
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/532/ : FAILURE
-- To view, visit http://gerrit.ovirt.org/7332 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I12478f64850dc3b3e421a562762c020819c8be28 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: generating uuid for libvirt configuration (#842115) ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(4 inline comments)
minor comments. I believe that this patch is not really dependent on the more complex former patch.
.................................................... Commit Message Line 4: Commit: Yaniv Bronhaim ybronhei@redhat.com Line 5: CommitDate: 2012-08-20 11:44:50 +0300 Line 6: Line 7: vdsm: generating uuid for libvirt configuration (#842115) Line 8: I'd mention that the real issue here is that hosts are sometimes shipped with non-unique uuid burned into their bios. Line 9: during migration we found that if both hosts as the same uuid Line 10: libvirt fails the migration. this fix generate uniqe uuid only Line 11: during vdsm reconfiguration. Line 12: this uuid is saved in libvirtd.conf file and ha sbeen used after
Line 8: Line 9: during migration we found that if both hosts as the same uuid Line 10: libvirt fails the migration. this fix generate uniqe uuid only Line 11: during vdsm reconfiguration. Line 12: this uuid is saved in libvirtd.conf file and ha sbeen used after ha sbeen -> is Line 13: libvirt service are restarted. Line 14: Line 15: Change-Id: I12478f64850dc3b3e421a562762c020819c8be28
Line 9: during migration we found that if both hosts as the same uuid Line 10: libvirt fails the migration. this fix generate uniqe uuid only Line 11: during vdsm reconfiguration. Line 12: this uuid is saved in libvirtd.conf file and ha sbeen used after Line 13: libvirt service are restarted. are -> is Line 14: Line 15: Change-Id: I12478f64850dc3b3e421a562762c020819c8be28
.................................................... File vdsm/vdsmd.init.in Line 346: set_if_default $lconf unix_sock_group "kvm" Line 347: set_if_default $lconf unix_sock_rw_perms "0770" Line 348: set_if_default $lconf auth_unix_rw "sasl" Line 349: set_if_default $qconf dynamic_ownership 0 Line 350: set_if_default $lconf host_uuid "$(uuidgen)" I'd join this line with the other $lconf changes. Line 351: Line 352: if [[ "$ssl" == true ]]; then Line 353: set_if_default $qconf spice_tls 1 Line 354: else
-- To view, visit http://gerrit.ovirt.org/7332 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I12478f64850dc3b3e421a562762c020819c8be28 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: generating uuid for libvirt configuration (#842115) ......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/534/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/7332 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I12478f64850dc3b3e421a562762c020819c8be28 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: generating uuid for libvirt configuration (#842115) ......................................................................
Patch Set 2: I would prefer that you didn't submit this
(2 inline comments)
I'm fine with the code, I have few comments on the comment that could use some spell-checking.
.................................................... Commit Message Line 3: AuthorDate: 2012-08-20 11:44:50 +0300 Line 4: Commit: Yaniv Bronhaim ybronhei@redhat.com Line 5: CommitDate: 2012-08-20 13:57:18 +0300 Line 6: Line 7: vdsm: generating uuid for libvirt configuration (#842115) until agreed otherwise, vdsm commits should begin with BZ# prefix. Line 8: Line 9: during migration we found that if both hosts as the same uuid Line 10: libvirt fails the migration. Sometimes host are shipped with Line 11: non-unique uuid burned into their bios.
Line 9: during migration we found that if both hosts as the same uuid Line 10: libvirt fails the migration. Sometimes host are shipped with Line 11: non-unique uuid burned into their bios. Line 12: this fix generate uniqe uuid for libvirt only during vdsm reconfiguration. Line 13: this uuid is saved in libvirtd.conf file and is been used after "is been used"? (English) Line 14: libvirt service is restarted. Line 15: Line 16: Change-Id: I12478f64850dc3b3e421a562762c020819c8be28
-- To view, visit http://gerrit.ovirt.org/7332 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I12478f64850dc3b3e421a562762c020819c8be28 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: BZ#842115 - Generating uuid for libvirt configuration ......................................................................
Patch Set 3:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/539/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/7332 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I12478f64850dc3b3e421a562762c020819c8be28 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#842115 - Generating uuid for libvirt configuration ......................................................................
Patch Set 3: Looks good to me, approved
Please have someone verify this patch: see that on installation the uuid is written and used by libvirt.
-- To view, visit http://gerrit.ovirt.org/7332 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I12478f64850dc3b3e421a562762c020819c8be28 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Yaniv Bronhaim has posted comments on this change.
Change subject: BZ#842115 - Generating uuid for libvirt configuration ......................................................................
Patch Set 3: Verified
This will configure new uuid to libvirt only after restarting libvirt.
Patch about restarting libvirt after setting new configuration is external to this patch and locates here: http://gerrit.ovirt.org/#/c/7331/
-- To view, visit http://gerrit.ovirt.org/7332 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I12478f64850dc3b3e421a562762c020819c8be28 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has submitted this change and it was merged.
Change subject: BZ#842115 - Generating uuid for libvirt configuration ......................................................................
BZ#842115 - Generating uuid for libvirt configuration
During migration we found that if both hosts as the same uuid libvirt fails the migration. Sometimes hosts are shipped with non-unique uuid burned into their bios. This fix generate uniqe uuid for libvirt only during vdsm reconfiguration. This uuid is saved in libvirtd.conf file and is used after libvirt service is restarted.
Change-Id: I12478f64850dc3b3e421a562762c020819c8be28 Signed-off-by: Yaniv Bronhaim ybronhei@redhat.com --- M vdsm/vdsmd.init.in 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: Yaniv Bronhaim: Verified Dan Kenigsberg: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/7332 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I12478f64850dc3b3e421a562762c020819c8be28 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org