Adam Litke has uploaded a new change for review.
Change subject: hook: balloon - Enable the virtio balloon ......................................................................
hook: balloon - Enable the virtio balloon
Currently the virtio balloon is disabled for vdsm guests. Until we decide to enable it by default, a hook is a convenient way to enable ballooning on a host. This hook simply replaces the model attribute of the memballoon tag from none to virtio.
Change-Id: Idc7d533268aff536179045db06b81e17c5fae3db Signed-off-by: Adam Litke agl@us.ibm.com --- M configure.ac M vdsm.spec.in M vdsm_hooks/Makefile.am A vdsm_hooks/balloon/Makefile.am A vdsm_hooks/balloon/before_vm_start.py 5 files changed, 63 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/16/4316/1 -- To view, visit http://gerrit.ovirt.org/4316 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Idc7d533268aff536179045db06b81e17c5fae3db Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com
Mark Wu has posted comments on this change.
Change subject: hook: balloon - Enable the virtio balloon ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm_hooks/balloon/before_vm_start.py Line 10: I think we need a condition check here, like: if hooking.tobool(os.environ.get('balloon', False)): That means only "balloon":True appears in the vm.conf['custom'], the hooking code can get chance to run.
Otherwise, this hook make balloon device added unconditionally. If adding a balloon device by default is acceptable, we can just remove the code setting balloon model to none instead of adding this hook.
So I suppose a switch for this hook is necessary.
-- To view, visit http://gerrit.ovirt.org/4316 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Idc7d533268aff536179045db06b81e17c5fae3db Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com
Adam Litke has posted comments on this change.
Change subject: hook: balloon - Enable the virtio balloon ......................................................................
Patch Set 1: (1 inline comment)
.................................................... File vdsm_hooks/balloon/before_vm_start.py Line 10: I thought about adding a flag, but I didn't want it to be necessary to set it for each VM on a host. I consider it a host setting whether balloons are enabled on a given host. Right now we cannot make this the default because we don't want to change the underlying device model for existing installed VMs until the next major release of oVirt.
-- To view, visit http://gerrit.ovirt.org/4316 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Idc7d533268aff536179045db06b81e17c5fae3db Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com
Mark Wu has posted comments on this change.
Change subject: hook: balloon - Enable the virtio balloon ......................................................................
Patch Set 1: No score
(1 inline comment)
I still think we need a flag for it and hope to get opinions from other guys.
.................................................... File vdsm_hooks/balloon/before_vm_start.py Line 10: I still think that we need a flag for it. If we don't want to bring impact to the existing VMs, we should have a switch to disable the hook. Let's say I have several VMs running on a host. After upgrading vdsm containing this hook, the underlying device address could change. Actually, I can't figure out what problems it will cause. But if we do have concern about it, then we should have option to avoid it.
-- To view, visit http://gerrit.ovirt.org/4316 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Idc7d533268aff536179045db06b81e17c5fae3db Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com
Itamar Heim has posted comments on this change.
Change subject: hook: balloon - Enable the virtio balloon ......................................................................
Patch Set 1:
still relevant with the set of patches around balloon going into engine?
-- To view, visit http://gerrit.ovirt.org/4316 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Idc7d533268aff536179045db06b81e17c5fae3db Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Itamar Heim iheim@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com
Adam Litke has abandoned this change.
Change subject: hook: balloon - Enable the virtio balloon ......................................................................
Patch Set 1: Abandoned
Since vdsm is getting first class support for ballooning, this hook will not be required.
-- To view, visit http://gerrit.ovirt.org/4316 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: Idc7d533268aff536179045db06b81e17c5fae3db Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Itamar Heim iheim@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com
vdsm-patches@lists.fedorahosted.org