Fabian Deutsch has uploaded a new change for review.
Change subject: vdsm-tool: Ensure that the vdsm uuid is a string ......................................................................
vdsm-tool: Ensure that the vdsm uuid is a string
Change-Id: I3c1f341dd66a468cf704158789e158f6d61f1d98 Signed-off-by: Fabian Deutsch fabiand@fedoraproject.org --- M lib/vdsm/tool/register.py 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/70/46970/1
diff --git a/lib/vdsm/tool/register.py b/lib/vdsm/tool/register.py index 47c8412..ae8fecd 100644 --- a/lib/vdsm/tool/register.py +++ b/lib/vdsm/tool/register.py @@ -271,8 +271,8 @@ os.unlink(__VDSM_ID)
if not os.path.exists(__VDSM_ID): - with open(__VDSM_ID, 'w') as f: - f.write(self.uuid) + with open(__VDSM_ID, 'wt') as f: + f.write(str(self.uuid))
if utils.isOvirtNode(): from ovirt.node.utils.fs import Config
automation@ovirt.org has posted comments on this change.
Change subject: vdsm-tool: Ensure that the vdsm uuid is a string ......................................................................
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-tool: Ensure that the vdsm uuid is a string ......................................................................
Patch Set 1: Code-Review+1
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm-tool: Ensure that the vdsm uuid is a string ......................................................................
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/46970/1/lib/vdsm/tool/register.py File lib/vdsm/tool/register.py:
Line 271: os.unlink(__VDSM_ID) Line 272: Line 273: if not os.path.exists(__VDSM_ID): Line 274: with open(__VDSM_ID, 'wt') as f: Line 275: f.write(str(self.uuid)) how could it ever NOT be a string? whomever attempted to set it to None or whatnot should be fixed, we need to add a blind conversion here. Line 276: Line 277: if utils.isOvirtNode(): Line 278: from ovirt.node.utils.fs import Config Line 279: Config().persist(__VDSM_ID)
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-tool: Ensure that the vdsm uuid is a string ......................................................................
Patch Set 1: Code-Review-1
Make sense dan's comment, moving to -1 as well.
vdsm-patches@lists.fedorahosted.org