Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: Isolate tcTests test properly ......................................................................
tests: Isolate tcTests test properly
Tests were sharing same devices - this is huge anti-pattern, as failure to delete a device in one test will cause the next test setup to fail.
Devices are created now in setUp() so each test has its own devices. Since tearDown() is not called if setUp() failed, setUp() is cleaning up on failures.
tearDown() was aborting early on the first error, possibly leaving stale devices around (breaking the next tests). Now all errors are logged and tearDown will fail if some devices could not be removed, revealing the errors in captured log.
Change-Id: I3861ccfb432541b63d7ba5814f7e3ae339ec8105 Signed-off-by: Nir Soffer nsoffer@redhat.com Reviewed-on: https://gerrit.ovirt.org/44144 Reviewed-by: Ido Barkan ibarkan@redhat.com Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg danken@redhat.com --- M tests/tcTests.py 1 file changed, 41 insertions(+), 23 deletions(-)
Approvals: Nir Soffer: Verified Ido Barkan: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved
vdsm-patches@lists.fedorahosted.org