Hello Zhou Zheng Sheng,
I'd like you to do a code review. Please visit
to review the following change.
Change subject: clean PEP 8 problems in vdsm/caps.py ......................................................................
clean PEP 8 problems in vdsm/caps.py
Change-Id: I000b2e63f31d1e2ca64e05d367b6b9e1b79d2cdf Signed-off-by: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com --- M Makefile.am M vdsm/caps.py 2 files changed, 41 insertions(+), 24 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/01/4801/1 -- To view, visit http://gerrit.ovirt.org/4801 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I000b2e63f31d1e2ca64e05d367b6b9e1b79d2cdf Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Shu Ming has posted comments on this change.
Change subject: Make vdsm/caps.py PEP8 clean ......................................................................
Patch Set 3: Verified
-- To view, visit http://gerrit.ovirt.org/4801 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I000b2e63f31d1e2ca64e05d367b6b9e1b79d2cdf Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Zhou Zheng Sheng has posted comments on this change.
Change subject: Make vdsm/caps.py PEP8 clean ......................................................................
Patch Set 3: Verified
The patch passes vdsm tests, and pydiff reports no differences found in code logic.
-- To view, visit http://gerrit.ovirt.org/4801 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I000b2e63f31d1e2ca64e05d367b6b9e1b79d2cdf Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: Make vdsm/caps.py PEP8 clean ......................................................................
Patch Set 3: I would prefer that you didn't submit this
currently requires non-trivial rebase.
and btw, sorry of the excessive noise of my scripted push of former patches.
-- To view, visit http://gerrit.ovirt.org/4801 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I000b2e63f31d1e2ca64e05d367b6b9e1b79d2cdf Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Shu Ming has abandoned this change.
Change subject: Make vdsm/caps.py PEP8 clean ......................................................................
Patch Set 3: Abandoned
This file will be covered in the next round of pep8 patches by Zhou Zheng Sheng. And new change ID will be used for this patch.
-- To view, visit http://gerrit.ovirt.org/4801 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: I000b2e63f31d1e2ca64e05d367b6b9e1b79d2cdf Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Shu Ming has posted comments on this change.
Change subject: Make vdsm/caps.py PEP8 clean ......................................................................
Patch Set 3:
See: http://gerrit.ovirt.org/#/c/5411/
-- To view, visit http://gerrit.ovirt.org/4801 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I000b2e63f31d1e2ca64e05d367b6b9e1b79d2cdf Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
vdsm-patches@lists.fedorahosted.org