Nir Soffer has uploaded a new change for review.
Change subject: resourceManager: Make ResourceMananger private
......................................................................
resourceManager: Make ResourceMananger private
Just to make sure that nobody will try to create its own instance
somewhere.
Change-Id: I35c3cffb4e1af8aa0f238c3501a82b975d56c2c3
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M tests/storage_resourcemanager_test.py
M vdsm/storage/resourceManager.py
2 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/65038/1
diff --git a/tests/storage_resourcemanager_test.py
b/tests/storage_resourcemanager_test.py
index 5859f61..d324670 100644
--- a/tests/storage_resourcemanager_test.py
+++ b/tests/storage_resourcemanager_test.py
@@ -115,9 +115,9 @@
def manager():
"""
- Create fresh ResourceManager instance for testing.
+ Create fresh _ResourceManager instance for testing.
"""
- manager = rm.ResourceManager()
+ manager = rm._ResourceManager()
manager.registerNamespace("storage", rm.SimpleResourceFactory())
manager.registerNamespace("null", NullResourceFactory())
manager.registerNamespace("string", StringResourceFactory())
diff --git a/vdsm/storage/resourceManager.py b/vdsm/storage/resourceManager.py
index a3b0c0e..20aa06c 100644
--- a/vdsm/storage/resourceManager.py
+++ b/vdsm/storage/resourceManager.py
@@ -330,7 +330,7 @@
repr(self.__wrappedObject) if self.isValid else None)
-class ResourceManager(object):
+class _ResourceManager(object):
"""
Manages all the resources in the application.
@@ -1007,7 +1007,7 @@
# The single resource manager - this instance is monkeypatched by the tests.
-_manager = ResourceManager()
+_manager = _ResourceManager()
# Public api - client should use only these to manage resources.
--
To view, visit
https://gerrit.ovirt.org/65038
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I35c3cffb4e1af8aa0f238c3501a82b975d56c2c3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>