Dan Kenigsberg has posted comments on this change.
Change subject: [WIP] Logging in OOP ......................................................................
Patch Set 2: (1 inline comment)
.................................................... File vdsm/storage/fileUtils.py Line 94: raise se.MountTypeError() Line 95: Line 96: log.error(">>>>>>>1 cmd=%s", str(cmd)) Line 97: rc, out, err = misc.execCmd(cmd) Line 98: log.error(">>>>>>>2 rc=%s out=%s err=%s", rc, out, err) do we really want this in production code? I think execCmd logs this anyway. Line 99: return rc Line 100: Line 101: def tarCopy(src, dst, exclude=[]): Line 102: excludeArgs = ["--exclude=%s" % path for path in exclude]
-- To view, visit http://gerrit.usersys.redhat.com/985 To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Iabe8abf31f46469e3c6fdac670f0ff03fe9cefe8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
vdsm-patches@lists.fedorahosted.org