Yaniv Bronhaim has uploaded a new change for review.
Change subject: infra: adding debug log to vdsm daemon init script ......................................................................
infra: adding debug log to vdsm daemon init script
Change-Id: I39ef7e19ede6eaed5c3f27b8c46f6f2b14dd08bd Signed-off-by: Yaniv Bronhaim ybronhei@redhat.com --- M vdsm/vdsmd.init.in 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/40/7340/1
diff --git a/vdsm/vdsmd.init.in b/vdsm/vdsmd.init.in index d34b48d..e664952 100755 --- a/vdsm/vdsmd.init.in +++ b/vdsm/vdsmd.init.in @@ -24,6 +24,7 @@ . @LIBEXECDIR@/ovirt_functions.sh
VDSM_BIN=@VDSMDIR@/vdsm +DEBUG_LOG=@VDSMDIR@/vdsmd.log CONF_FILE=@CONFDIR@/vdsm.conf GETCONFITEM=@VDSMDIR@/get-conf-item prog=vdsm @@ -47,6 +48,7 @@
. /etc/init.d/functions
+debug_log() { [[ -n "$DEBUG" ]] && (echo "$*" >> $DEBUG_LOG) } log_failure_msg() { echo -n "$@"; failure "$@"; echo; } log_success_msg() { echo -n "$@"; success "$@"; echo; }
-- To view, visit http://gerrit.ovirt.org/7340 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I39ef7e19ede6eaed5c3f27b8c46f6f2b14dd08bd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: infra: adding debug log to vdsm daemon init script ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/536/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/7340 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I39ef7e19ede6eaed5c3f27b8c46f6f2b14dd08bd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: infra: adding debug log to vdsm daemon init script ......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/557/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/7340 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I39ef7e19ede6eaed5c3f27b8c46f6f2b14dd08bd Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Eli Mesika has posted comments on this change.
Change subject: infra: adding debug log to vdsm daemon init script ......................................................................
Patch Set 2: (4 inline comments)
.................................................... File vdsm/vdsmd.init.in Line 47: SYSTEMCTL_SKIP_REDIRECT=true Line 48: Line 49: . /etc/init.d/functions Line 50: Line 51: debug_log() { [[ -n "$DEBUG" ]] && (echo "$*" >> $DEBUG_LOG) } why $* if you are using only $1 in all calls ? Line 52: log_failure_msg() { echo -n "$@"; failure "$@"; echo; } Line 53: log_success_msg() { echo -n "$@"; success "$@"; echo; } Line 54: Line 55: check_port_taken() {
Line 160: Line 161: for srv in $NEEDED_SERVICES Line 162: do Line 163: if ! /sbin/service $srv status > /dev/null 2>&1; # Verify that status is inactive Line 164: then please remove TLS Line 165: echo "Starting $srv..." Line 166: /sbin/service $srv start Line 167: ret_val=$? Line 168: if [ $ret_val -ne 0 ]
Line 179: test_lo() { Line 180: if ! LC_ALL=C /sbin/ifconfig lo | /bin/grep -q UP; Line 181: then Line 182: log_failure_msg "VDSMD: lo interface is down, can't run !" Line 183: echo "VDSMD: lo interface is down, can't run !" > /dev/kmsg same Line 184: return 1 Line 185: fi Line 186: return 0 Line 187: }
Line 471: ret_val=$? Line 472: if [ $ret_val -ne 0 ] Line 473: then Line 474: log_failure_msg "$prog: one of the dependent services did not start, error code $ret_val" Line 475: debug_log "error starting ext srvs" why use short-cuts for a log message ? it should be detailed Line 476: return $ret_val Line 477: fi Line 478: Line 479: @VDSMDIR@/vdsm-restore-net-config
-- To view, visit http://gerrit.ovirt.org/7340 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I39ef7e19ede6eaed5c3f27b8c46f6f2b14dd08bd Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eli Mesika emesika@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: infra: adding debug log to vdsm daemon init script ......................................................................
Patch Set 3:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/568/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/7340 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I39ef7e19ede6eaed5c3f27b8c46f6f2b14dd08bd Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eli Mesika emesika@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Douglas Schilling Landgraf has posted comments on this change.
Change subject: infra: adding debug log to vdsm daemon init script ......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm/vdsmd.init.in Line 161: for srv in $NEEDED_SERVICES Line 162: do Line 163: if ! /sbin/service $srv status > /dev/null 2>&1; # Verify that status is inactive Line 164: then Line 165: echo "Starting $srv..." Looks like a lost tab here. Line 166: /sbin/service $srv start Line 167: ret_val=$? Line 168: if [ $ret_val -ne 0 ] Line 169: then
-- To view, visit http://gerrit.ovirt.org/7340 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I39ef7e19ede6eaed5c3f27b8c46f6f2b14dd08bd Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eli Mesika emesika@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: infra: adding debug log to vdsm daemon init script ......................................................................
Patch Set 4:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/573/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/7340 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I39ef7e19ede6eaed5c3f27b8c46f6f2b14dd08bd Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eli Mesika emesika@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: infra: adding debug log to vdsm daemon init script ......................................................................
Patch Set 5:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/576/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/7340 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I39ef7e19ede6eaed5c3f27b8c46f6f2b14dd08bd Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eli Mesika emesika@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Yaniv Bronhaim has abandoned this change.
Change subject: infra: adding debug log to vdsm daemon init script ......................................................................
Patch Set 5: Abandoned
this uploaded by mistake
-- To view, visit http://gerrit.ovirt.org/7340 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: I39ef7e19ede6eaed5c3f27b8c46f6f2b14dd08bd Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eli Mesika emesika@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Yaniv Bronhaim has restored this change.
Change subject: infra: adding debug log to vdsm daemon init script ......................................................................
Patch Set 5: Restored
-- To view, visit http://gerrit.ovirt.org/7340 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: restore Gerrit-Change-Id: I39ef7e19ede6eaed5c3f27b8c46f6f2b14dd08bd Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eli Mesika emesika@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Douglas Schilling Landgraf has posted comments on this change.
Change subject: infra: adding debug log to vdsm daemon init script ......................................................................
Patch Set 5: I would prefer that you didn't submit this
(2 inline comments)
.................................................... File vdsm/vdsmd.init.in Line 160: Line 161: for srv in $NEEDED_SERVICES Line 162: do Line 163: if ! /sbin/service $srv status > /dev/null 2>&1; # Verify that status is inactive Line 164: then looks like an additional space Line 165: echo "Starting $srv..." Line 166: /sbin/service $srv start Line 167: ret_val=$? Line 168: if [ $ret_val -ne 0 ]
Line 179: test_lo() { Line 180: if ! LC_ALL=C /sbin/ifconfig lo | /bin/grep -q UP; Line 181: then Line 182: log_failure_msg "VDSMD: lo interface is down, can't run !" Line 183: echo "VDSMD: lo interface is down, can't run !" > /dev/kmsg looks like an additional space Line 184: return 1 Line 185: fi Line 186: return 0 Line 187: }
-- To view, visit http://gerrit.ovirt.org/7340 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I39ef7e19ede6eaed5c3f27b8c46f6f2b14dd08bd Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eli Mesika emesika@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: infra: adding debug log to vdsm daemon init script ......................................................................
Patch Set 6:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/593/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/7340 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I39ef7e19ede6eaed5c3f27b8c46f6f2b14dd08bd Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eli Mesika emesika@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Yaniv Bronhaim has posted comments on this change.
Change subject: infra: adding debug log to vdsm daemon init script ......................................................................
Patch Set 6: Verified
-- To view, visit http://gerrit.ovirt.org/7340 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I39ef7e19ede6eaed5c3f27b8c46f6f2b14dd08bd Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eli Mesika emesika@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: infra: adding debug log to vdsm daemon init script ......................................................................
Patch Set 6: I would prefer that you didn't submit this
(1 inline comment)
I think it would be nice if you not only define the function, but also use it - I think it makes sense to call it in log_failure_msg/log_success_msg.
.................................................... File vdsm/vdsmd.init.in Line 47: SYSTEMCTL_SKIP_REDIRECT=true Line 48: Line 49: . /etc/init.d/functions Line 50: Line 51: debug_log() { [[ -n "$DEBUG" ]] && (echo "$*" >> $DEBUG_LOG) } I see no point in creating another shell process - that what happens with parentheses. Line 52: log_failure_msg() { echo -n "$@"; failure "$@"; echo; } Line 53: log_success_msg() { echo -n "$@"; success "$@"; echo; } Line 54: Line 55: check_port_taken() {
-- To view, visit http://gerrit.ovirt.org/7340 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I39ef7e19ede6eaed5c3f27b8c46f6f2b14dd08bd Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eli Mesika emesika@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: infra: adding debug log to vdsm daemon init script ......................................................................
Patch Set 6:
hmm, maybe I should have asked if using bash's -x and -v options is not helpful even more than this suggested log.
-- To view, visit http://gerrit.ovirt.org/7340 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I39ef7e19ede6eaed5c3f27b8c46f6f2b14dd08bd Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eli Mesika emesika@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Yaniv Bronhaim has posted comments on this change.
Change subject: infra: adding debug log to vdsm daemon init script ......................................................................
Patch Set 7: Verified
-- To view, visit http://gerrit.ovirt.org/7340 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I39ef7e19ede6eaed5c3f27b8c46f6f2b14dd08bd Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eli Mesika emesika@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: infra: adding debug log to vdsm daemon init script ......................................................................
Patch Set 7:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/609/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/7340 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I39ef7e19ede6eaed5c3f27b8c46f6f2b14dd08bd Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eli Mesika emesika@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Eli Mesika has posted comments on this change.
Change subject: infra: adding debug log to vdsm daemon init script ......................................................................
Patch Set 7: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/7340 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I39ef7e19ede6eaed5c3f27b8c46f6f2b14dd08bd Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eli Mesika emesika@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: infra: adding debug log to vdsm daemon init script ......................................................................
Patch Set 7: I would prefer that you didn't submit this
I think it would be nice if you not only define the function, but also use it - I think it makes sense to call it in log_failure_msg/log_success_msg.
-- To view, visit http://gerrit.ovirt.org/7340 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I39ef7e19ede6eaed5c3f27b8c46f6f2b14dd08bd Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eli Mesika emesika@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: infra: adding debug log to vdsm daemon init script ......................................................................
Patch Set 7:
but really. please explain the motivation of this. why running the script with -xv is not enough for debugging?
-- To view, visit http://gerrit.ovirt.org/7340 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I39ef7e19ede6eaed5c3f27b8c46f6f2b14dd08bd Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eli Mesika emesika@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Yaniv Bronhaim has posted comments on this change.
Change subject: infra: adding debug log to vdsm daemon init script ......................................................................
Patch Set 7:
I made this separate patch because you asked me on http://gerrit.ovirt.org/#/c/7331/. I use this log on this patch and need it to debug the service initialization when using service controller processes to initialize vdsmd.
-- To view, visit http://gerrit.ovirt.org/7340 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I39ef7e19ede6eaed5c3f27b8c46f6f2b14dd08bd Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eli Mesika emesika@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Yaniv Bronhaim has abandoned this change.
Change subject: infra: adding debug log to vdsm daemon init script ......................................................................
Patch Set 7: Abandoned
-- To view, visit http://gerrit.ovirt.org/7340 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: I39ef7e19ede6eaed5c3f27b8c46f6f2b14dd08bd Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eli Mesika emesika@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org