Francesco Romani has uploaded a new change for review.
Change subject: doc: add basic quickstart for containers ......................................................................
doc: add basic quickstart for containers
Change-Id: I0fb768ea97dd719cde9bd5e57e1b7cabe4b0f0ae Signed-off-by: Francesco Romani fromani@redhat.com --- M README 1 file changed, 57 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/24/59824/1
diff --git a/README b/README index 955dfa9..370028e 100644 --- a/README +++ b/README @@ -32,6 +32,63 @@ The 'vdsm.spec' file demonstrates how to distribute Vdsm as an RPM package.
+Containers support +================== + +While Vdsm focus is on managing KVM virtual machines, it could also run +containers alongside virtual machines using popular formats and runtimes, +such as rkt and appc images. + +Containers are reported as special-purpose VMs to the clients, and responds +to the Vdsm API invoked on them. +If a particular container runtime doesn't support an operation, this will +fail with a standard Vdsm error. + +To try this out, you just need to install the 'vdsm-containers subpackage'. +Make sure to restart *both* supervdsmd and vdsmd once that package is installed. +You'll also need to have the container runtime you wish to use installed on +the same host which runs Vdsm. The supported runtimes are: + +- rkt (main supported runtime) +- runc (work in progress) +- docker (very experimental) + +The supported image container formats depend on the container runtime. +For example, modern rkt could run docker images transparently. + +To check if the Vdsm is properly configured to run containers, just do: + +# vdsClient -s 0 getVdsCaps | grep containers + + containers = ['rkt'] + +This means that this Vdsm could also run containers using `rkt`. + +Any Engine >= 3.6 could handle containers - they are just VMs from its perspective. +You just need to set few custom properties. Run this command +on your Engine host: + +# engine-config -s UserDefinedVMProperties='volumeMap=^[a-zA-Z_-]+:[a-zA-Z_-]+$;containerImage=^[a-zA-Z]+(://|)[a-zA-Z]+$;containerType=^(rkt|docker)$' --cver=3.6 + +replace --cver=3.6 with the version of the Engine you are using. +Now restart Ovirt Engine, and log in. + +You can now run any container. The user defined VM properties define +the key settings which are not (yet) exposed in the engine UI. + +- volumeMap allows you to mount any disk inside the container, should you + need any persistence. It is a mapping between disks (e.g. vda) + and mountpoint (e.g. data). The mountpoints are just container-dependent labels. + +- containerImage is the URL or path of any container image supported by your + runtime. E.g. 'docker://redis' + +- containerType allows to select the runtime you want to use (e.g. rkt) + +Please be aware that many settings are ignored by containers, like all +the device configurations. Only memory and CPU settings are honoured. + + Getting Help ============
gerrit-hooks has posted comments on this change.
Change subject: doc: add basic quickstart for containers ......................................................................
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: doc: add basic quickstart for containers ......................................................................
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: core: containers: bundle former 'convirt' in Vdsm ......................................................................
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: core: containers: bundle former 'convirt' in Vdsm ......................................................................
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: core: containers: bundle former 'convirt' in Vdsm ......................................................................
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Martin Polednik has posted comments on this change.
Change subject: core: containers: bundle former 'convirt' in Vdsm ......................................................................
Patch Set 7:
Thing to bear in mind: at least cgroups is a module that I would love to see in VDSM's library due to it being "the supported way" of determining information needed to construct NUMA mapping.
gerrit-hooks has posted comments on this change.
Change subject: core: containers: add the container support module ......................................................................
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: core: containers: add the container support module ......................................................................
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: core: containers: add the container support module ......................................................................
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: core: containers: add the container support module ......................................................................
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: core: containers: add the container support module ......................................................................
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: core: containers: add the container support module ......................................................................
Patch Set 13:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: core: containers: add the container support module ......................................................................
Patch Set 14:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: core: containers: add the container support module ......................................................................
Patch Set 15:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: core: containers: add the container support module ......................................................................
Patch Set 16:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: core: containers: add the container support module ......................................................................
Patch Set 17:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: core: containers: add the container support module ......................................................................
Patch Set 18:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: core: containers: add the container support module ......................................................................
Patch Set 19:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: core: containers: add the container support module ......................................................................
Patch Set 20:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: core: containers: add the container support module ......................................................................
Patch Set 21:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: core: containers: add the container support module ......................................................................
Patch Set 22:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: core: containers: add the container support module ......................................................................
Patch Set 23:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: core: containers: add the container support module ......................................................................
Patch Set 24:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: core: containers: add the container support module ......................................................................
Patch Set 25:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Martin Polednik has posted comments on this change.
Change subject: core: containers: add the container support module ......................................................................
Patch Set 25:
(15 comments)
partialr eview
https://gerrit.ovirt.org/#/c/59824/25/lib/vdsm/virt/containers/config/__init... File lib/vdsm/virt/containers/config/__init__.py:
PS25, Line 26: class AttrDict(MutableMapping): Do we *really* **need** this? Also, it's scope is broader than containers/config.
https://gerrit.ovirt.org/#/c/59824/25/lib/vdsm/virt/containers/config/networ... File lib/vdsm/virt/containers/config/network.py:
PS25, Line 34: subnet='10.1.0.0', why?
PS25, Line 34: subnet='10.1.0.0', Also, this is enough addresses for 65534. How many containers can beefy virtualization host run?
https://gerrit.ovirt.org/#/c/59824/25/lib/vdsm/virt/containers/events.py File lib/vdsm/virt/containers/events.py:
PS25, Line 87: : # for testing purposes : def clear(self): : with self._lock: : self.events.clear() I don't think it's my first time saying this, but we should not pollute module API with testing utilities.
PS25, Line 99: root.fire(event_id, dom, *args) As a linux/unix user, I feel unsafe seeing this. :) Can you spare a few words on the name, do you expect it to be a proper hierarchy?
https://gerrit.ovirt.org/#/c/59824/25/lib/vdsm/virt/containers/fs.py File lib/vdsm/virt/containers/fs.py:
PS25, Line 31: def rm_file(target): Why separate module within containers? There is utils rmFile. If you consider rmFile wrong, fix it first.
PS25, Line 42: def read_file(path): : with open(path, 'rt') as f: : return f.read() I'm unsure of the benefit of having this in a function within containers.
https://gerrit.ovirt.org/#/c/59824/25/lib/vdsm/virt/containers/metrics/cgrou... File lib/vdsm/virt/containers/metrics/cgroups.py:
PS25, Line 24: cgroups is linux-specific So is VDSM.
PS25, Line 36: Stats = None This could really use class type hint. Not sure if easily possible.
PS25, Line 126: pass # we don't support some cgroups Why?
PS25, Line 152: @property : def cgroups(self): : return self._cgroups : : @property : def pid(self): : return self._pid There is no reason for these to be property. We can move them to properties if some more sophisticated get/set action is needed.
PS25, Line 166: def _read_keyvalue(path, sep=' '): I have a feeling we do already have such function, and if not, many reimplementations of the same thing. Do we really need new one?
Why is it not a part of Reader?
https://gerrit.ovirt.org/#/c/59824/25/lib/vdsm/virt/containers/xmlfile.py File lib/vdsm/virt/containers/xmlfile.py:
PS25, Line 35: class UnconfiguredXML(Exception): Uhm, to avoid having to read the docstring to understand the exception, what about MissingXML?
PS25, Line 47: encoding = 'unicode' if six.PY3 else 'utf-8' I'd expect PY4 to keep the unicode.
PS25, Line 66: cached Is this really a cache?
gerrit-hooks has posted comments on this change.
Change subject: core: containers: add the container support module ......................................................................
Patch Set 26:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: core: containers: add the container support module ......................................................................
Patch Set 27:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: core: containers: add the container support module ......................................................................
Patch Set 28:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: core: containers: add the container support module ......................................................................
Patch Set 29:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: core: containers: add the container support module ......................................................................
Patch Set 30:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: core: containers: add the container support module ......................................................................
Patch Set 31:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Francesco Romani has posted comments on this change.
Change subject: core: containers: add the container support module ......................................................................
Patch Set 25:
(15 comments)
https://gerrit.ovirt.org/#/c/59824/25/lib/vdsm/virt/containers/config/__init... File lib/vdsm/virt/containers/config/__init__.py:
PS25, Line 26: class AttrDict(MutableMapping):
Do we *really* **need** this? Also, it's scope is broader than containers/c
Surely not, it was just nicer to me. It is a relic of the times on which convirt was an external, isolated project. Let me try to kill it.
https://gerrit.ovirt.org/#/c/59824/25/lib/vdsm/virt/containers/config/networ... File lib/vdsm/virt/containers/config/network.py:
PS25, Line 34: subnet='10.1.0.0',
why?
No good reason, I copied from somewhere so I don't have a clear rationale for that.
https://gerrit.ovirt.org/#/c/59824/25/lib/vdsm/virt/containers/events.py File lib/vdsm/virt/containers/events.py:
PS25, Line 87: : # for testing purposes : def clear(self): : with self._lock: : self.events.clear()
I don't think it's my first time saying this, but we should not pollute mod
surely it is not your first time, will clear this up
PS25, Line 99: root.fire(event_id, dom, *args)
As a linux/unix user, I feel unsafe seeing this. :) Can you spare a few wor
will add a proper focstring.
https://gerrit.ovirt.org/#/c/59824/25/lib/vdsm/virt/containers/fs.py File lib/vdsm/virt/containers/fs.py:
PS25, Line 31: def rm_file(target):
Why separate module within containers? There is utils rmFile. If you consid
(applies to the following comment too) again, relic of times on which convirt was external module. We don't actually need this module anymore, will remove it.
https://gerrit.ovirt.org/#/c/59824/25/lib/vdsm/virt/containers/metrics/cgrou... File lib/vdsm/virt/containers/metrics/cgroups.py:
PS25, Line 24: cgroups is linux-specific
So is VDSM.
Good point, will remove this comment.
PS25, Line 36: Stats = None
This could really use class type hint. Not sure if easily possible.
Will look into this.
PS25, Line 126: pass # we don't support some cgroups
Why?
it is a pending TODO :)
PS25, Line 152: @property : def cgroups(self): : return self._cgroups : : @property : def pid(self): : return self._pid
There is no reason for these to be property. We can move them to properties
Right. I just dislike those to be externally modifiable. But let's trust people here.
PS25, Line 166: def _read_keyvalue(path, sep=' '):
I have a feeling we do already have such function, and if not, many reimple
Will kill duplication.
Part of reader: doesn't use any of the Reader state, so one could argue it doesn't belong there :)
https://gerrit.ovirt.org/#/c/59824/25/lib/vdsm/virt/containers/xmlfile.py File lib/vdsm/virt/containers/xmlfile.py:
PS25, Line 35: class UnconfiguredXML(Exception):
Uhm, to avoid having to read the docstring to understand the exception, wha
Better, will rename
PS25, Line 47: encoding = 'unicode' if six.PY3 else 'utf-8'
I'd expect PY4 to keep the unicode.
right, let's reverse this check.
PS25, Line 66: cached
Is this really a cache?
This - no. So the message is confusing and will be removed. The point is that this XML is saved once the VM is started and never changed; the FS acts as a cache here.
PS25, Line 71: cached same
PS25, Line 76: cached same
Francesco Romani has posted comments on this change.
Change subject: core: containers: add the container support module ......................................................................
Patch Set 31: Code-Review-1
TL;DR - kill duplication, improve docstrings.
gerrit-hooks has posted comments on this change.
Change subject: core: containers: add the container support module ......................................................................
Patch Set 32:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: core: containers: add the container support module ......................................................................
Patch Set 33:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Martin Polednik has posted comments on this change.
Change subject: core: containers: add the container support module ......................................................................
Patch Set 33:
(11 comments)
https://gerrit.ovirt.org/#/c/59824/33/lib/vdsm/virt/containers/command.py File lib/vdsm/virt/containers/command.py:
PS33, Line 2: 2008- That doesn't seem right to me.
PS33, Line 45: def __repr__(self): : return "%s: %s" % ( : self.name, : 'not found in %r' % self._paths : if self._cmd is None else self._cmd, : ) Format is much nicer.
PS33, Line 52: @property : def name(self): : return self._name cls.name (considering s/_name/name) is already property, this doesn't add any value.
PS33, Line 95: # TODO document the purpose Yes please. This smells like a redundancy to https://gerrit.ovirt.org/#/c/56491/31/vdsm/supervdsm_api/systemd.py incl. the Path class. Most of the module does.
https://gerrit.ovirt.org/#/c/59824/33/lib/vdsm/virt/containers/doms.py File lib/vdsm/virt/containers/doms.py:
PS33, Line 45: return list(_doms.values()) # py3 compat Love this compared to six.iteritems.
PS33, Line 63: # use only for testing : def clear(): : with _lock: : _doms.clear() Same as every other test leak. Please move the functionality to tests.
https://gerrit.ovirt.org/#/c/59824/33/lib/vdsm/virt/containers/events.py File lib/vdsm/virt/containers/events.py:
PS33, Line 28: body func?
PS33, Line 31: def _null_cb(*args, **kwargs): : pass : : : _NULL = Callback(None, None, _null_cb, tuple()) I'd move this to get_callbacks unless it has any reason to exist elsewhere.
PS33, Line 80: self._log.warning('[%s] unhandled event %r', self._name, event_id) I find this confusing. I'd expect "unhandled event" to be logged when the event is triggered, not when looking up it's callbacks.
PS33, Line 88: # for testing purposes : def clear(self): : with self._lock: : self.events.clear() As said elsewhere, this is test implementation leak. Shouldn't be mixed w/ runtime code.
PS33, Line 98: global root ??
gerrit-hooks has posted comments on this change.
Change subject: core: containers: add the container support module ......................................................................
Patch Set 34:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: core: containers: add the container support module ......................................................................
Patch Set 35:
* Update Tracker::IGNORE, no bug url/s found * Check Bug-Url::IGNORE, not relevant for branch: master * Check Public Bug::WARN, no public bug url found * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: core: containers: add the container support module ......................................................................
Patch Set 36:
* Update Tracker::IGNORE, no bug url/s found * Check Bug-Url::IGNORE, not relevant for branch: master * Check Public Bug::WARN, no public bug url found * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: core: containers: add the container support module ......................................................................
Patch Set 37:
* Update Tracker::IGNORE, no bug url/s found * Check Bug-Url::IGNORE, not relevant for branch: master * Check Public Bug::WARN, no public bug url found * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: core: containers: add the container support module ......................................................................
Patch Set 38:
* Update Tracker::IGNORE, no bug url/s found * Check Bug-Url::IGNORE, not relevant for branch: master * Check Public Bug::WARN, no public bug url found * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: core: containers: add the container support module ......................................................................
Patch Set 39:
* Update Tracker::IGNORE, no bug url/s found * Check Bug-Url::IGNORE, not relevant for branch: master * Check Public Bug::WARN, no public bug url found * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: core: containers: add the container support module ......................................................................
Patch Set 40:
* Update Tracker::IGNORE, no bug url/s found * Check Bug-Url::IGNORE, not relevant for branch: master * Check Public Bug::WARN, no public bug url found * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
From Dan Kenigsberg danken@redhat.com:
Dan Kenigsberg has posted comments on this change.
Change subject: core: containers: add the container support module ......................................................................
Patch Set 60: Code-Review+2
From Dan Kenigsberg danken@redhat.com:
Dan Kenigsberg has posted comments on this change.
Change subject: core: containers: add the container support module ......................................................................
Patch Set 61: Continuous-Integration+1
sorry, this ff-only is a pain when CI is unreliable.
DEBUG util.py:421: failure: repodata/486c936a72b1d31db8b5892cb0c0372ba3c171509f168c1c24b5e32d5bf11861-primary.sqlite.xz from epel: [Errno 256] No more mirrors to try.
From Dan Kenigsberg danken@redhat.com:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: core: containers: add the container support module ......................................................................
core: containers: add the container support module
Add module to run containers using the libvirt API.
Change-Id: I0fb768ea97dd719cde9bd5e57e1b7cabe4b0f0ae Signed-off-by: Francesco Romani fromani@redhat.com --- M README.md M configure.ac M lib/vdsm/containersconnection.py M lib/vdsm/virt/Makefile.am A lib/vdsm/virt/containers/Makefile.am A lib/vdsm/virt/containers/__init__.py A lib/vdsm/virt/containers/cgroups.py A lib/vdsm/virt/containers/command.py A lib/vdsm/virt/containers/connection.py A lib/vdsm/virt/containers/docker.py A lib/vdsm/virt/containers/domain.py A lib/vdsm/virt/containers/doms.py A lib/vdsm/virt/containers/errors.py A lib/vdsm/virt/containers/events.py A lib/vdsm/virt/containers/monitoring.py A lib/vdsm/virt/containers/runner.py A lib/vdsm/virt/containers/xmlfile.py M vdsm.spec.in 18 files changed, 1,415 insertions(+), 0 deletions(-)
Approvals: Dan Kenigsberg: Looks good to me, approved; Passed CI tests Francesco Romani: Verified Martin Polednik: Looks good to me, but someone else must approve Milan Zamazal: Looks good to me, but someone else must approve
Objections: Jenkins CI: Failed CI tests
vdsm-patches@lists.fedorahosted.org