Shahar Havivi has uploaded a new change for review.
Change subject: Create payload directory if not exists ......................................................................
Create payload directory if not exists
Change-Id: Iddd51bc064b8e2c51820dd6e541264faf493a61f Signed-off-by: Shahar Havivi shavivi@redhat.com Signed-off-by: Shahar Havivi shaharh@redhat.com --- M vdsm/mkimage.py 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/48/4248/1 -- To view, visit http://gerrit.ovirt.org/4248 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Iddd51bc064b8e2c51820dd6e541264faf493a61f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shavivi@redhat.com
Shahar Havivi has posted comments on this change.
Change subject: Create payload directory if not exists ......................................................................
Patch Set 1: Verified
-- To view, visit http://gerrit.ovirt.org/4248 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Iddd51bc064b8e2c51820dd6e541264faf493a61f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shavivi@redhat.com Gerrit-Reviewer: Shahar Havivi shavivi@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Create payload directory if not exists ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm/mkimage.py Line 61: os.mkdir(_P_PAYLOAD_IMAGES) it is better to do
try: os.mkdir(_P_PAYLOAD_IMAGES) except IOError: pass
-- To view, visit http://gerrit.ovirt.org/4248 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Iddd51bc064b8e2c51820dd6e541264faf493a61f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shavivi@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Shahar Havivi shavivi@redhat.com
Shahar Havivi has posted comments on this change.
Change subject: Create payload directory if not exists ......................................................................
Patch Set 1: (1 inline comment)
.................................................... File vdsm/mkimage.py Line 61: os.mkdir(_P_PAYLOAD_IMAGES) Done
-- To view, visit http://gerrit.ovirt.org/4248 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Iddd51bc064b8e2c51820dd6e541264faf493a61f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shavivi@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Shahar Havivi shavivi@redhat.com
Shahar Havivi has posted comments on this change.
Change subject: Create payload directory if not exists ......................................................................
Patch Set 2: Verified
-- To view, visit http://gerrit.ovirt.org/4248 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Iddd51bc064b8e2c51820dd6e541264faf493a61f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shavivi@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Shahar Havivi shavivi@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Create payload directory if not exists ......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm/mkimage.py Line 63: except IOError: I now see that I've mislead you. Could you do what Federico does in
http://gerrit.ovirt.org/#patch,sidebyside,4250,2,vdsm_reg/deployUtil.py.in
-- To view, visit http://gerrit.ovirt.org/4248 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Iddd51bc064b8e2c51820dd6e541264faf493a61f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shavivi@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Shahar Havivi shavivi@redhat.com
Shahar Havivi has posted comments on this change.
Change subject: Create payload directory if not exists ......................................................................
Patch Set 2: (1 inline comment)
.................................................... File vdsm/mkimage.py Line 63: except IOError: Done
-- To view, visit http://gerrit.ovirt.org/4248 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Iddd51bc064b8e2c51820dd6e541264faf493a61f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shavivi@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Shahar Havivi shavivi@redhat.com
Shahar Havivi has posted comments on this change.
Change subject: Create payload directory if not exists ......................................................................
Patch Set 3: Verified
-- To view, visit http://gerrit.ovirt.org/4248 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Iddd51bc064b8e2c51820dd6e541264faf493a61f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shavivi@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Shahar Havivi shavivi@redhat.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Create payload directory if not exists ......................................................................
Create payload directory if not exists
Change-Id: Iddd51bc064b8e2c51820dd6e541264faf493a61f Signed-off-by: Shahar Havivi shaharh@redhat.com --- M vdsm/mkimage.py 1 file changed, 6 insertions(+), 0 deletions(-)
Approvals: Shahar Havivi: Verified Dan Kenigsberg: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/4248 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: Iddd51bc064b8e2c51820dd6e541264faf493a61f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shavivi@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Shahar Havivi shavivi@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Create payload directory if not exists ......................................................................
Patch Set 3: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/4248 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Iddd51bc064b8e2c51820dd6e541264faf493a61f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shavivi@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Shahar Havivi shavivi@redhat.com
vdsm-patches@lists.fedorahosted.org