Hello Bing Bu Cao,
I'd like you to do a code review. Please visit
to review the following change.
Change subject: Fixing pep8 in vdsm/hooks.py ......................................................................
Fixing pep8 in vdsm/hooks.py
Change-Id: I3aec8fff9e1dd48237e6896118d407fc9eb331b9 Signed-off-by: Cao,Bing Bu mars@linux.vnet.ibm.com --- M Makefile.am M vdsm/hooks.py 2 files changed, 41 insertions(+), 9 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/95/4795/1 -- To view, visit http://gerrit.ovirt.org/4795 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I3aec8fff9e1dd48237e6896118d407fc9eb331b9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com
Bing Bu Cao has posted comments on this change.
Change subject: Fixing pep8 in vdsm/hooks.py ......................................................................
Patch Set 1: (1 inline comment)
.................................................... File vdsm/hooks.py Line 46: I think it will be better if the "if" statement is alignment with 's' in the upper line.
-- To view, visit http://gerrit.ovirt.org/4795 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I3aec8fff9e1dd48237e6896118d407fc9eb331b9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com
Bing Bu Cao has posted comments on this change.
Change subject: Fixing pep8 in vdsm/hooks.py ......................................................................
Patch Set 1:
I have updated my change before to new sets.
-- To view, visit http://gerrit.ovirt.org/4795 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I3aec8fff9e1dd48237e6896118d407fc9eb331b9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com
Zhou Zheng Sheng has posted comments on this change.
Change subject: Fixing pep8 in vdsm/hooks.py ......................................................................
Patch Set 1: Verified
The patch passes tests in vdsm. And I compare the old file and new file with a tool named pydiff.py(https://github.com/edwardbadboy/pydiff). It can says there is no logic change in the file.
-- To view, visit http://gerrit.ovirt.org/4795 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I3aec8fff9e1dd48237e6896118d407fc9eb331b9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Zhou Zheng Sheng has posted comments on this change.
Change subject: Fixing pep8 in vdsm/hooks.py ......................................................................
Patch Set 2: Verified
Test patch set 2 using the same method in patch set 1. Patch set 2 passes the tests.
-- To view, visit http://gerrit.ovirt.org/4795 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I3aec8fff9e1dd48237e6896118d407fc9eb331b9 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Shu Ming has posted comments on this change.
Change subject: Make vdsm/hooks.py PEP8 clean ......................................................................
Patch Set 3: Verified
-- To view, visit http://gerrit.ovirt.org/4795 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I3aec8fff9e1dd48237e6896118d407fc9eb331b9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Zhou Zheng Sheng has posted comments on this change.
Change subject: Make vdsm/hooks.py PEP8 clean ......................................................................
Patch Set 3: Verified
Test patch set 3 using the same method in patch set 1. Patch set 3 passes the tests.
-- To view, visit http://gerrit.ovirt.org/4795 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I3aec8fff9e1dd48237e6896118d407fc9eb331b9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: Make vdsm/hooks.py PEP8 clean ......................................................................
Patch Set 4: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/4795 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I3aec8fff9e1dd48237e6896118d407fc9eb331b9 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Make vdsm/hooks.py PEP8 clean ......................................................................
Make vdsm/hooks.py PEP8 clean
Change-Id: I3aec8fff9e1dd48237e6896118d407fc9eb331b9 Signed-off-by: Cao,Bing Bu mars@linux.vnet.ibm.com --- M Makefile.am M vdsm/hooks.py 2 files changed, 41 insertions(+), 9 deletions(-)
Approvals: Dan Kenigsberg: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/4795 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I3aec8fff9e1dd48237e6896118d407fc9eb331b9 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
vdsm-patches@lists.fedorahosted.org