From Dan Kenigsberg danken@redhat.com:
Dan Kenigsberg has posted comments on this change.
Change subject: ssl: enable tlsv1.2 support
......................................................................
Patch Set 27:
(1 comment)
https://gerrit.ovirt.org/#/c/72284/27/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
PS27, Line 227: tlsv1.2
the text of the bug agrees with it, too
please note that my idea suggest that you dynamically look for the constant value with
getattr(ssl, whatever_in_the_conf_file)
so you don't need any hard-coded values for protocols, only to warn or crash if you have an invalid value.
--
To view, visit
https://gerrit.ovirt.org/72284
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cc83d8cc08349a0ca47ed7d021bb3fc6d1408a6
Gerrit-PatchSet: 27
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
piotr.kliczewski@gmail.com
Gerrit-Reviewer: Dan Kenigsberg
danken@redhat.com
Gerrit-Reviewer: Francesco Romani
fromani@redhat.com
Gerrit-Reviewer: Irit Goihman
igoihman@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina
mperina@redhat.com
Gerrit-Reviewer: Michal Skrivanek
michal.skrivanek@redhat.com
Gerrit-Reviewer: Nir Soffer
nsoffer@redhat.com
Gerrit-Reviewer: Piotr Kliczewski
piotr.kliczewski@gmail.com
Gerrit-Reviewer: Yaniv Bronhaim
ybronhei@redhat.com
Gerrit-Reviewer: gerrit-hooks
automation@ovirt.org
Gerrit-HasComments: Yes