From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. (
https://gerrit.ovirt.org/78592 )
Change subject: tests: Remove global panic mocking
......................................................................
tests: Remove global panic mocking
Global mocking of the panic function requires using our non-standard
test runner. We want to be able to run any test using existing tests
runners like py.test. Tests that needs to mock panic.panic() should
monkey-patch it during the test.
The old panic tests was testing the panic mock; replace the test with a
test testing the real code.
Change-Id: I8ceebdc2ae2d457e9be1b8121327f50a7fa4bfd0
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M tests/Makefile.am
A tests/panic_helper.py
M tests/testrunner.py
M tests/utils_test.py
4 files changed, 14 insertions(+), 12 deletions(-)
Approvals:
Nir Soffer: Verified
Jenkins CI: Passed CI tests
Irit Goihman: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
--
To view, visit
https://gerrit.ovirt.org/78592
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8ceebdc2ae2d457e9be1b8121327f50a7fa4bfd0
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>