Mark Wu has uploaded a new change for review.
Change subject: Remove 'skipLibvirt' from NetworkOptions ......................................................................
Remove 'skipLibvirt' from NetworkOptions
The option 'skipLibvirt' was removed in commit ccb07ae. So it should be removed from schema too. Signed-off-by: Mark Wu wudxw@linux.vnet.ibm.com
Change-Id: I41ff1f6686bfa448fd0b5953dd1d2983290d651c Signed-off-by: Mark Wu wudxw@linux.vnet.ibm.com --- M vdsm_api/vdsmapi-schema.json 1 file changed, 1 insertion(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/86/7286/1
diff --git a/vdsm_api/vdsmapi-schema.json b/vdsm_api/vdsmapi-schema.json index 13a5bc9..fba27c1 100644 --- a/vdsm_api/vdsmapi-schema.json +++ b/vdsm_api/vdsmapi-schema.json @@ -64,14 +64,12 @@ # # @bondingOptions: #optional A string of space-separated <option>=<value> pairs # -# @skipLibvirt: #optional Do not use libvirt to gather network information -# # Since: 4.10.0 ## {'type': 'NetworkOptions', 'data': {'*ipaddr', 'str', '*netmask': 'str', '*gateway': 'str', '*bootproto': 'str', '*delay': 'uint', '*onboot': 'str', - '*bondingOptions', 'str', 'skipLibvirt': 'bool'}} + '*bondingOptions', 'str'}}
## # @Global.addNetwork:
-- To view, visit http://gerrit.ovirt.org/7286 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I41ff1f6686bfa448fd0b5953dd1d2983290d651c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Remove 'skipLibvirt' from NetworkOptions ......................................................................
Patch Set 1:
Build Failed
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/491/ : ABORTED
-- To view, visit http://gerrit.ovirt.org/7286 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I41ff1f6686bfa448fd0b5953dd1d2983290d651c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: Remove 'skipLibvirt' from NetworkOptions ......................................................................
Patch Set 1: Looks good to me, approved
Thanks for this cleanup!
-- To view, visit http://gerrit.ovirt.org/7286 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I41ff1f6686bfa448fd0b5953dd1d2983290d651c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Mark Wu has posted comments on this change.
Change subject: Remove 'skipLibvirt' from NetworkOptions ......................................................................
Patch Set 1: Verified
-- To view, visit http://gerrit.ovirt.org/7286 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I41ff1f6686bfa448fd0b5953dd1d2983290d651c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Remove 'skipLibvirt' from NetworkOptions ......................................................................
Remove 'skipLibvirt' from NetworkOptions
The option 'skipLibvirt' was removed in commit ccb07ae. So it should be removed from schema too. Signed-off-by: Mark Wu wudxw@linux.vnet.ibm.com
Change-Id: I41ff1f6686bfa448fd0b5953dd1d2983290d651c Signed-off-by: Mark Wu wudxw@linux.vnet.ibm.com --- M vdsm_api/vdsmapi-schema.json 1 file changed, 1 insertion(+), 3 deletions(-)
Approvals: Mark Wu: Verified Dan Kenigsberg: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/7286 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I41ff1f6686bfa448fd0b5953dd1d2983290d651c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org