Saggi Mizrahi has uploaded a new change for review.
Change subject: Remove redundant indiration for getting vm status ......................................................................
Remove redundant indiration for getting vm status
Change-Id: I789155bb2dc1b7df911c949c08567c8f34b600ee Signed-off-by: Saggi Mizrahi smizrahi@redhat.com --- M vdsm/libvirtvm.py 1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/21/7421/1
diff --git a/vdsm/libvirtvm.py b/vdsm/libvirtvm.py index 7d95f3f..3ff3a01 100644 --- a/vdsm/libvirtvm.py +++ b/vdsm/libvirtvm.py @@ -1420,7 +1420,7 @@ self.saveState() self._getUnderlyingNetworkInterfaceInfo()
- return {'status': doneCode, 'vmList': self.cif.vmContainer[params['vmId']].status()} + return {'status': doneCode, 'vmList': self.status()}
def hotunplugNic(self, params): if self.isMigrating(): @@ -1472,7 +1472,7 @@ return {'status' : {'code': errCode['hotunplugNic']['status']['code'], 'message': e.message}}
- return {'status': doneCode, 'vmList': self.cif.vmContainer[params['vmId']].status()} + return {'status': doneCode, 'vmList': self.status()}
def hotplugDisk(self, params): if self.isMigrating(): @@ -1508,7 +1508,7 @@ self.saveState() self._getUnderlyingDriveInfo()
- return {'status': doneCode, 'vmList': self.cif.vmContainer[params['vmId']].status()} + return {'status': doneCode, 'vmList': self.status()}
def hotunplugDisk(self, params): if self.isMigrating(): @@ -1563,7 +1563,7 @@ else: self._cleanup()
- return {'status': doneCode, 'vmList': self.cif.vmContainer[params['vmId']].status()} + return {'status': doneCode, 'vmList': self.status()}
def _readPauseCode(self, timeout): self.log.warning('_readPauseCode unsupported by libvirt vm')
-- To view, visit http://gerrit.ovirt.org/7421 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I789155bb2dc1b7df911c949c08567c8f34b600ee Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Remove redundant indiration for getting vm status ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/600/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/7421 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I789155bb2dc1b7df911c949c08567c8f34b600ee Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: Remove redundant indiration for getting vm status ......................................................................
Patch Set 1: Looks good to me, approved
If it was not my project, I would have laughed at
self.cif.vmContainer[params['vmId']] == self
!
-- To view, visit http://gerrit.ovirt.org/7421 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I789155bb2dc1b7df911c949c08567c8f34b600ee Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Remove redundant indiration for getting vm status ......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/645/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/7421 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I789155bb2dc1b7df911c949c08567c8f34b600ee Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Remove redundant indirection for getting vm status ......................................................................
Patch Set 3:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/692/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/7421 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I789155bb2dc1b7df911c949c08567c8f34b600ee Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Adam Litke has posted comments on this change.
Change subject: Remove redundant indirection for getting vm status ......................................................................
Patch Set 3: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/7421 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I789155bb2dc1b7df911c949c08567c8f34b600ee Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: Remove redundant indirection for getting vm status ......................................................................
Patch Set 3: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/7421 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I789155bb2dc1b7df911c949c08567c8f34b600ee Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Remove redundant indirection for getting vm status ......................................................................
Remove redundant indirection for getting vm status
Change-Id: I789155bb2dc1b7df911c949c08567c8f34b600ee Signed-off-by: Saggi Mizrahi smizrahi@redhat.com --- M vdsm/libvirtvm.py 1 file changed, 4 insertions(+), 8 deletions(-)
Approvals: Adam Litke: Looks good to me, but someone else must approve Dan Kenigsberg: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/7421 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I789155bb2dc1b7df911c949c08567c8f34b600ee Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org