From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: vm: create a vnic with vhostuser backend
......................................................................
Patch Set 31:
(1 comment)
https://gerrit.ovirt.org/#/c/74327/31/lib/vdsm/virt/vmdevices/network.py
File lib/vdsm/virt/vmdevices/network.py:
Line 303: detach_detachable(self.hostdev)
Line 304: else:
Line 305: bridge_info = supervdsm.getProxy().ovs_bridge(self.network)
Line 306: if bridge_info and bridge_info['dpdk_enabled']:
Line 307: self._is_vhostuser = True
This becomes too complicated.
It's sad that we need to
store data just in order not to bother supervdsm during __init__. But yes, it's my
option 1.
I kinda likeMartin's suggestion. in vm.py we can have
if not self.recovering:
self._setup_devices()
else:
self._recover_devices() # <== add this
which should call a device.recover() which would speak with supervdsm.
Line 308: self._create_vhost_port(bridge_info['name'])
Line 309:
Line 310: def teardown(self):
Line 311: if self.is_hostdevice:
--
To view, visit
https://gerrit.ovirt.org/74327
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie81cf52f17ffe01713dd6502d68c4b17c64e5335
Gerrit-PatchSet: 31
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes