Mark Wu has posted comments on this change.
Change subject: Move option 'save_image_format' to qemu.conf
......................................................................
Patch Set 1: (1 inline comment)
....................................................
Commit Message
Line 10: so move it to qemu.conf.
This option is only used to create image, not used to read image. Libvirt adds a header to
the image file, which contains a field of compress type. It can choose right program to
decompress according the image header. So I think it's safe to change it.
Thanks to libvirt already covering it.
By the way, do we really want to use lzop? If yes, I think we need add a requires of it.
Otherwise, it will fail to hibernate a vm on a host which doesn't have it installed.
Because of the wrong location of the option, libvirt just use the default option
'raw' to save image. So no problem reported even without lzop.
--
To view, visit
http://gerrit.ovirt.org/5928
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I55d3e33783071cacbc71a31c5c46083e99fe65d1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>