Yaniv Bronhaim has uploaded a new change for review.
Change subject: Remove python-argparse requirement ......................................................................
Remove python-argparse requirement
This package has been obsoleted in Fedora because it got in to stdlib.
Change-Id: I4b9e46427eece4987082344b0936f51ce300f39e Signed-off-by: Yaniv Bronhaim ybronhei@redhat.com --- M vdsm.spec.in 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/62/64162/1
diff --git a/vdsm.spec.in b/vdsm.spec.in index c09b9a9..abe5f7e 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -138,7 +138,6 @@ Requires: PyYAML Requires: python-netaddr Requires: python-inotify -Requires: python-argparse Requires: python-cpopen >= 1.4 Requires: python-ioprocess >= 0.16.1-1 Requires: python-pthreading >= 0.1.3-3
gerrit-hooks has posted comments on this change.
Change subject: Remove python-argparse requirement ......................................................................
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Yaniv Bronhaim has posted comments on this change.
Change subject: Remove python-argparse requirement ......................................................................
Patch Set 1:
cstratak reached me in irc as python maintainer and asked to remove this requirement from our spec now when its part of stdlib. it used to be Provides by python2.7 so we it was redundant anyway. but now he wants to remove this Provides as he plans to rename it to python2-argparse and this will break our build
Nir Soffer has posted comments on this change.
Change subject: Remove python-argparse requirement ......................................................................
Patch Set 1: Code-Review+1
Piotr Kliczewski has posted comments on this change.
Change subject: Remove python-argparse requirement ......................................................................
Patch Set 1: Code-Review+1
Yaniv Bronhaim has posted comments on this change.
Change subject: Remove python-argparse requirement ......................................................................
Patch Set 1: Verified+1
Dan Kenigsberg has posted comments on this change.
Change subject: Remove python-argparse requirement ......................................................................
Patch Set 1: Code-Review+2
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Remove python-argparse requirement ......................................................................
Remove python-argparse requirement
This package has been obsoleted in Fedora because it got in to stdlib.
Change-Id: I4b9e46427eece4987082344b0936f51ce300f39e Signed-off-by: Yaniv Bronhaim ybronhei@redhat.com Reviewed-on: https://gerrit.ovirt.org/64162 Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer nsoffer@redhat.com Reviewed-by: Piotr Kliczewski piotr.kliczewski@gmail.com Reviewed-by: Dan Kenigsberg danken@redhat.com --- M vdsm.spec.in 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Nir Soffer: Looks good to me, but someone else must approve Yaniv Bronhaim: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved
gerrit-hooks has posted comments on this change.
Change subject: Remove python-argparse requirement ......................................................................
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found.
vdsm-patches@lists.fedorahosted.org