Eduardo Warszawski has posted comments on this change.
Change subject: Generalize _parseDriveSpec dictionaries. ......................................................................
Patch Set 1: (1 inline comment)
This patches fixed the case of one item dictionary which is actually broken. In addition t\his patch is a dependency.
.................................................... File vdsm_cli/vdsClient.py Line 1341: Line 1342: #TODO: Remove this and the references to domainID (etc) key. Line 1343: def _splitDriveSpecItems(self, item): Line 1344: """ Line 1345: BC is BC. Backward compatibility. Line 1346: """ Line 1347: key, value = item.split(":", 1) Line 1348: if key in ("domain", "pool", "image", "volume"): Line 1349: key = "%sID" % key
-- To view, visit http://gerrit.usersys/1063 To unsubscribe, visit http://gerrit.usersys/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I24350c099a92923323a221c909c53855a2906ece Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Warszawski ewarszaw@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo Warszawski ewarszaw@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
vdsm-patches@lists.fedorahosted.org