Igor Lvovsky has uploaded a new change for review.
Change subject: BZ#846312 - Keep max MTU when adding non-VLANed bridgeless network ......................................................................
BZ#846312 - Keep max MTU when adding non-VLANed bridgeless network
Change-Id: Ie9c05b9ebcba298d1ab897e2ac5b979c3c9ea29b Signed-off-by: Igor Lvovsky ilvovsky@redhat.com --- M vdsm/configNetwork.py 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/77/7477/1
diff --git a/vdsm/configNetwork.py b/vdsm/configNetwork.py index 8f01657..af7bcac 100755 --- a/vdsm/configNetwork.py +++ b/vdsm/configNetwork.py @@ -831,7 +831,7 @@ configWriter = ConfigWriter()
prevmtu = None - if mtu and vlan: + if mtu: prevmtu = configWriter.getMaxMtu(nics, mtu)
nic = nics[0] if nics else None
-- To view, visit http://gerrit.ovirt.org/7477 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Ie9c05b9ebcba298d1ab897e2ac5b979c3c9ea29b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#846312 - Keep max MTU when adding non-VLANed bridgeless network ......................................................................
Patch Set 1: Looks good to me, approved
hmm, was the original "and vlan" a premature optimization?
-- To view, visit http://gerrit.ovirt.org/7477 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie9c05b9ebcba298d1ab897e2ac5b979c3c9ea29b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: BZ#846312 - Keep max MTU when adding non-VLANed bridgeless network ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/673/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/7477 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie9c05b9ebcba298d1ab897e2ac5b979c3c9ea29b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Igor Lvovsky has posted comments on this change.
Change subject: BZ#846312 - Keep max MTU when adding non-VLANed bridgeless network ......................................................................
Patch Set 1: Verified
-- To view, visit http://gerrit.ovirt.org/7477 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie9c05b9ebcba298d1ab897e2ac5b979c3c9ea29b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has submitted this change and it was merged.
Change subject: BZ#846312 - Keep max MTU when adding non-VLANed bridgeless network ......................................................................
BZ#846312 - Keep max MTU when adding non-VLANed bridgeless network
Change-Id: Ie9c05b9ebcba298d1ab897e2ac5b979c3c9ea29b Signed-off-by: Igor Lvovsky ilvovsky@redhat.com --- M vdsm/configNetwork.py 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Dan Kenigsberg: Looks good to me, approved Igor Lvovsky: Verified
-- To view, visit http://gerrit.ovirt.org/7477 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: Ie9c05b9ebcba298d1ab897e2ac5b979c3c9ea29b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org