Federico Simoncelli has posted comments on this change.
Change subject: Handle EAGAIN and EINTR in ProcessPool.runExternally ......................................................................
Patch Set 1:
This avoids stuff like:
MainThread::WARNING::2011-10-21 12:38:33,532::persistentDict::150::Storage.PersistentDict::(transaction) Error in transaction, rolling back changes Traceback (most recent call last): File "/usr/share/vdsm/storage/persistentDict.py", line 147, in transaction self.flush(self._metadata) File "/usr/share/vdsm/storage/persistentDict.py", line 266, in flush self._metaRW.writelines(lines) File "/usr/share/vdsm/storage/fileSD.py", line 58, in writelines self._oop.writeLines(tmpFilePath, metadata) File "/usr/share/vdsm/storage/processPool.py", line 33, in wrapper return self.runExternally(func, *args, **kwds) File "/usr/share/vdsm/storage/processPool.py", line 44, in runExternally return self._procPool.runExternally(*args, **kwargs) File "/usr/share/vdsm/storage/processPool.py", line 113, in runExternally if not helper.pipe.poll(self.timeout): IOError: [Errno 4] Interrupted system call
-- To view, visit http://gerrit.usersys.redhat.com/1051 To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Id1d0f35af9db6e237c87b00438b9ce3ded9faa8f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
vdsm-patches@lists.fedorahosted.org