From Dan Kenigsberg danken@redhat.com:
Dan Kenigsberg has posted comments on this change.
Change subject: api: log only external pings ......................................................................
Patch Set 13: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/78142/13//COMMIT_MSG Commit Message:
Line 15: is successful (pinged from localhost) although the host lost its Line 16: network connectivity. Line 17: Line 18: With this patch we confirm connectivity (touch P_VDSM_CLIENT_LOG) Line 19: only when ping is used by a non-localhost caller. per discussion with Petr, I am convinced that we cannot just change the existing verb (since there still might be someone running Engine on a Vdsm host).
We'd better deprecate ping, and create 2 new verbs: - ping2 (or echo or whatever to check connectivity) - confirm_connectivity (for explict confirmation of connectivity) Line 20: Line 21: Change-Id: I9eff40244f38d5707f9e1cec64d20bcd68415b2d
vdsm-patches@lists.fedorahosted.org