Federico Simoncelli has uploaded a new change for review.
Change subject: Add the hasHostId method to the cluster locks ......................................................................
Add the hasHostId method to the cluster locks
Signed-off-by: Federico Simoncelli fsimonce@redhat.com Change-Id: Ic1df6c5451e2a976b7fd4e86409705742c5e050e --- M vdsm/storage/safelease.py M vdsm/storage/sd.py 2 files changed, 21 insertions(+), 16 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/27/3927/1 -- To view, visit http://gerrit.ovirt.org/3927 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Ic1df6c5451e2a976b7fd4e86409705742c5e050e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com
Saggi Mizrahi has posted comments on this change.
Change subject: Add the hasHostId method to the cluster locks ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/3927 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ic1df6c5451e2a976b7fd4e86409705742c5e050e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Maor Lipchuk has posted comments on this change.
Change subject: Add the hasHostId method to the cluster locks ......................................................................
Patch Set 13: (1 inline comment)
Looks good to me, see comment inline
.................................................... File vdsm/storage/safelease.py Line 191: "status, returning False", exc_info=True) I don't see reference to argument in the log, so why use the exc_info=True for?
-- To view, visit http://gerrit.ovirt.org/3927 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ic1df6c5451e2a976b7fd4e86409705742c5e050e Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipchuk@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Federico Simoncelli has posted comments on this change.
Change subject: Add the hasHostId method to the cluster locks ......................................................................
Patch Set 13: (1 inline comment)
.................................................... File vdsm/storage/safelease.py Line 191: "status, returning False", exc_info=True) We are using exc_info=True to have the complete traceback in the logs (so that we can see all the information about the error reported by sanlock).
-- To view, visit http://gerrit.ovirt.org/3927 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ic1df6c5451e2a976b7fd4e86409705742c5e050e Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipchuk@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Allon Mureinik has posted comments on this change.
Change subject: Add the hasHostId method to the cluster locks ......................................................................
Patch Set 14: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/3927 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ic1df6c5451e2a976b7fd4e86409705742c5e050e Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Allon Mureinik amureini@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipchuk@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Allon Mureinik has posted comments on this change.
Change subject: Add the hasHostId method to the cluster locks ......................................................................
Patch Set 15: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/3927 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ic1df6c5451e2a976b7fd4e86409705742c5e050e Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Allon Mureinik amureini@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipchuk@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Maor Lipchuk has posted comments on this change.
Change subject: Add the hasHostId method to the cluster locks ......................................................................
Patch Set 16: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/3927 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ic1df6c5451e2a976b7fd4e86409705742c5e050e Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Allon Mureinik amureini@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipchuk@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Haim Ateya has posted comments on this change.
Change subject: Add the hasHostId method to the cluster locks ......................................................................
Patch Set 16: Verified
-- To view, visit http://gerrit.ovirt.org/3927 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ic1df6c5451e2a976b7fd4e86409705742c5e050e Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Allon Mureinik amureini@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipchuk@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Federico Simoncelli has posted comments on this change.
Change subject: Add the hasHostId method to the cluster locks ......................................................................
Patch Set 16: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/3927 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ic1df6c5451e2a976b7fd4e86409705742c5e050e Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Allon Mureinik amureini@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipchuk@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Add the hasHostId method to the cluster locks ......................................................................
Add the hasHostId method to the cluster locks
Signed-off-by: Federico Simoncelli fsimonce@redhat.com Change-Id: Ic1df6c5451e2a976b7fd4e86409705742c5e050e --- M vdsm/storage/safelease.py M vdsm/storage/sd.py 2 files changed, 21 insertions(+), 16 deletions(-)
Approvals: Haim Ateya: Verified Federico Simoncelli: Looks good to me, approved Dan Kenigsberg: Maor Lipchuk: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/3927 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: Ic1df6c5451e2a976b7fd4e86409705742c5e050e Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Allon Mureinik amureini@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipchuk@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
vdsm-patches@lists.fedorahosted.org