New patch submitted by Eduardo Warszawski (ewarszaw@redhat.com)
You can review this change at: http://gerrit.usersys.redhat.com/774
commit f9df164fcaeda9000d7ccae5cf267ac1dca342cb Author: Eduardo Warszawski ewarszaw@redhat.com Date: Tue Aug 2 10:38:45 2011 +0300
FIXUP simplify getDomains.
Change-Id: I90a7faa9211a76b340521ef6ece830406156c27a
diff --git a/vdsm/storage/sp.py b/vdsm/storage/sp.py index 6483985..8430955 100644 --- a/vdsm/storage/sp.py +++ b/vdsm/storage/sp.py @@ -1188,9 +1188,7 @@ class StoragePool: self.log.error("Unexpected error while trying to monitor domain `%s`", sdUUID, exc_info=True)
def getDomains(self, activeOnly=False): - isActive = lambda v: True if not activeOnly else v == sd.DOM_ACTIVE_STATUS - return dict((k, v) for k, v in self.getMetaParam(PMDK_DOMAINS).iteritems() if isActive(v)) - + return dict((sdUUID, status) for sdUUID, status in self.getMetaParam(PMDK_DOMAINS).iteritems() if not activeOnly or status == sd.DOM_ACTIVE_STATUS) def checkBackupDomain(self): domDict = self.getDomains(activeOnly=True) for sdUUID in domDict:
Eduardo Warszawski has abandoned this change.
Change subject: FIXUP simplify getDomains. ......................................................................
Patch Set 1: Abandoned
Submission mistake
-- To view, visit http://gerrit.usersys.redhat.com/774 To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: I90a7faa9211a76b340521ef6ece830406156c27a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Warszawski ewarszaw@redhat.com
vdsm-patches@lists.fedorahosted.org