Federico Simoncelli has uploaded a new change for review.
Change subject: Make domainMonitor compliant to PEP8 ......................................................................
Make domainMonitor compliant to PEP8
Signed-off-by: Federico Simoncelli fsimonce@redhat.com Change-Id: Ie707eed5a132704378f0fd61f57e84e527fbc06d --- M Makefile.am M vdsm/storage/domainMonitor.py 2 files changed, 24 insertions(+), 14 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/28/3928/1 -- To view, visit http://gerrit.ovirt.org/3928 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Ie707eed5a132704378f0fd61f57e84e527fbc06d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com
Saggi Mizrahi has posted comments on this change.
Change subject: Make domainMonitor compliant to PEP8 ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/3928 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie707eed5a132704378f0fd61f57e84e527fbc06d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Saggi Mizrahi has posted comments on this change.
Change subject: Make domainMonitor compliant to PEP8 ......................................................................
Patch Set 3: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/3928 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie707eed5a132704378f0fd61f57e84e527fbc06d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Make domainMonitor compliant to PEP8 ......................................................................
Patch Set 16: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File Makefile.am Line 70: vdsm/storage/localFsSD.py \ why check twice?
-- To view, visit http://gerrit.ovirt.org/3928 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie707eed5a132704378f0fd61f57e84e527fbc06d Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Zhou Zheng Sheng has posted comments on this change.
Change subject: Make domainMonitor compliant to PEP8 ......................................................................
Patch Set 17: Verified
(1 inline comment)
Passes tests in vdsm.
pydiff found some changes. After examine the corresponding lines, I think the changes are acceptable.
pydiff detailed report: pydiff domainMonitor*.py 4 difference(s) first file: domainMonitoro.py second file: domainMonitor.py
((73, 'st'), (78, 'status'))
((77, 'st'), (81, 'status'))
((80, 'st'), (85, 'status'))
((130, "Subscript(Dict([(Name('True'), Const('valid')), (Name('False'), Const('Invalid'))]), 'OP_APPLY', [Getattr(Name('nextStatus'), 'valid')])"), (137, "IfExp(Getattr(Name('nextStatus'), 'valid'), Const('Valid'), Const('Invalid'))"))
The first 3 are changing a variable name. It's a local variable, and all occurrences are changed. The last change is acceptable as well if you look at the code.
.................................................... File vdsm/storage/domainMonitor.py Line 31: "vgMdFreeBelowThreashold") PEP 8 says "Continuation lines should align wrapped elements either vertically using Python's implicit line joining inside parentheses, brackets and braces, or using a hanging indent." http://www.python.org/dev/peps/pep-0008/#indentation
So it would be nice here to write: __slots__ = ("error", "lastCheck", "valid", "readDelay", "masterMounted", "masterValid", "diskUtilization", "vgMdUtilization", "vgMdHasEnoughFreeSpace", "vgMdFreeBelowThreashold")
-- To view, visit http://gerrit.ovirt.org/3928 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie707eed5a132704378f0fd61f57e84e527fbc06d Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Ayal Baron has posted comments on this change.
Change subject: Make domainMonitor compliant to PEP8 ......................................................................
Patch Set 17: Looks good to me, but someone else must approve
Please note previous comment about aligning "slots" (can be a different patch so +1ing)
-- To view, visit http://gerrit.ovirt.org/3928 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie707eed5a132704378f0fd61f57e84e527fbc06d Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Maor Lipchuk has posted comments on this change.
Change subject: Make domainMonitor compliant to PEP8 ......................................................................
Patch Set 17: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/3928 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie707eed5a132704378f0fd61f57e84e527fbc06d Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipchuk@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Make domainMonitor compliant to PEP8 ......................................................................
Make domainMonitor compliant to PEP8
Signed-off-by: Federico Simoncelli fsimonce@redhat.com Change-Id: Ie707eed5a132704378f0fd61f57e84e527fbc06d --- M Makefile.am M vdsm/storage/domainMonitor.py 2 files changed, 24 insertions(+), 14 deletions(-)
Approvals: Ayal Baron: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Maor Lipchuk: Looks good to me, but someone else must approve Zhou Zheng Sheng: Verified
-- To view, visit http://gerrit.ovirt.org/3928 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: Ie707eed5a132704378f0fd61f57e84e527fbc06d Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipchuk@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: Make domainMonitor compliant to PEP8 ......................................................................
Patch Set 17: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/3928 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie707eed5a132704378f0fd61f57e84e527fbc06d Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipchuk@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
vdsm-patches@lists.fedorahosted.org