Royce Lv has uploaded a new change for review.
Change subject: Modify pthread.py compile to pep8 ......................................................................
Modify pthread.py compile to pep8
Change-Id: I466da79448d6004fc17a01586c81d4758016c3be Signed-off-by: Royce Lvlvroyce@linux.vnet.ibm.com --- M Makefile.am M vdsm/pthread.py 2 files changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/31/4531/1 -- To view, visit http://gerrit.ovirt.org/4531 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I466da79448d6004fc17a01586c81d4758016c3be Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: Modify pthread.py comply to pep8 ......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File Makefile.am Line 48: vdsm/pthread.py \ how come your editor thinks that a tab is 4 spaces? ;-)
-- To view, visit http://gerrit.ovirt.org/4531 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I466da79448d6004fc17a01586c81d4758016c3be Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Royce Lv has posted comments on this change.
Change subject: Modify pthread.py comply to pep8 ......................................................................
Patch Set 2: (1 inline comment)
.................................................... File Makefile.am Line 48: vdsm/pthread.py \ Sorry, that is because I set wrong vim tag
-- To view, visit http://gerrit.ovirt.org/4531 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I466da79448d6004fc17a01586c81d4758016c3be Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Zhou Zheng Sheng has posted comments on this change.
Change subject: Modify pthread.py comply to pep8 ......................................................................
Patch Set 5: (1 inline comment)
A small problem in Makefile.am. Please refer to inline comment.
.................................................... File Makefile.am Line 48: vdsm/pthread.py \ Need tab here. If you set expandtab in vim, you can insert a real tab by pressing ctrl+v then the tab key. Or you can delete tab related settings in .vimrc and add this lines:
autocmd FileType python setlocal tabstop=4 shiftwidth=4 expandtab softtabstop=4 autocmd BufEnter *.py setlocal tabstop=4 shiftwidth=4 expandtab softtabstop=4
Now vim only expand tab for you when editing Python source files.
-- To view, visit http://gerrit.ovirt.org/4531 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I466da79448d6004fc17a01586c81d4758016c3be Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Zhou Zheng Sheng has posted comments on this change.
Change subject: Modify pthread.py comply to pep8 ......................................................................
Patch Set 5: (1 inline comment)
.................................................... File Makefile.am Line 48: vdsm/pthread.py \ I mean:
autocmd FileType python setlocal tabstop=4 shiftwidth=4 expandtab softtabstop=4
autocmd BufEnter *.py setlocal tabstop=4 shiftwidth=4 expandtab softtabstop=4
gerrit made two lines into one line, sorry.
-- To view, visit http://gerrit.ovirt.org/4531 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I466da79448d6004fc17a01586c81d4758016c3be Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: Modify pthread.py comply to pep8 ......................................................................
Patch Set 5: I would prefer that you didn't submit this
setting -1 for Zhou Zheng Sheng's comment.
-- To view, visit http://gerrit.ovirt.org/4531 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I466da79448d6004fc17a01586c81d4758016c3be Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Royce Lv has abandoned this change.
Change subject: Modify pthread.py comply to pep8 ......................................................................
Patch Set 5: Abandoned
submiitted a new one
-- To view, visit http://gerrit.ovirt.org/4531 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: I466da79448d6004fc17a01586c81d4758016c3be Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
vdsm-patches@lists.fedorahosted.org