Irit Goihman has posted comments on this change.
Change subject: functional tests: fix supervdsmServer test
......................................................................
Patch Set 9:
(5 comments)
https://gerrit.ovirt.org/#/c/61902/8/tests/functional/supervdsmFuncTests.py
File tests/functional/supervdsmFuncTests.py:
Line 32:
Line 33:
Line 34: class TestSuperVdsmRemotly(TestCaseBase):
Line 35: def testPingCall(self):
Line 36: p = subprocess.Popen(
please verify that in the mock it runs that
Done
Line 37: ['./run_tests.sh', 'functional/test_ping_call.py'])
Line 38: out, err = p.communicate()
Line 39: self.assertEqual(p.returncode, 0)
Line 40:
Line 37: ['./run_tests.sh', 'functional/test_ping_call.py'])
Line 38: out, err = p.communicate()
Line 39: self.assertEqual(p.returncode, 0)
Line 40:
Line 41: def testKsmAction(self):
you can use self.assert[False\Equal]
Done
Line 42: p = subprocess.Popen(
Line 43: ['./run_tests.sh', 'functional/test_ksm_action.py'])
Line 44: out, err = p.communicate()
Line 39: self.assertEqual(p.returncode, 0)
Line 40:
Line 41: def testKsmAction(self):
Line 42: p = subprocess.Popen(
Line 43: ['./run_tests.sh', 'functional/test_ksm_action.py'])
and if tmpfs is not mounted? should we have a check for that?
Done
Line 44: out, err = p.communicate()
https://gerrit.ovirt.org/#/c/61902/8/tests/functional/test_ksm_action.py
File tests/functional/test_ksm_action.py:
Line 19: from os import path
Line 20: import sys
Line 21: sys.path.append(path.dirname(path.dirname(path.abspath(__file__))))
Line 22:
Line 23: from testlib import VdsmTestCase
if you can do that, you can also do "from
functional.superVdsFuncTests impo
line 21 should solve testlib import
Line 24: import testValidation
Line 25: from vdsm import supervdsm
Line 26:
Line 27: from supervdsmFuncTests import dropPrivileges
Line 36: ksmParams = {"run": 0,
Line 37: "merge_across_nodes": 1,
Line 38: "sleep_millisecs": 0xffff,
Line 39: "pages_to_scan": 0xffff}
Line 40: proxy.ksmTune(ksmParams)
its an helper for superVdsTests, its not a noisetest. do the logic in
__mai
Done
Line 41: for k, v in ksmParams.iteritems():
Line 42: self.assertEqual(
--
To view, visit
https://gerrit.ovirt.org/61902
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c7e381809261cf330ef4f19c3fec5cd38254b1b
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes