From Dan Kenigsberg danken@redhat.com:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Report empty LLDP TLV lists for operational down interfaces ......................................................................
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/80339/4//COMMIT_MSG Commit Message:
Line 4: Commit: Dominik Holler dholler@redhat.com Line 5: CommitDate: 2017-08-08 09:10:55 +0200 Line 6: Line 7: net: Report empty LLDP TLV lists for operational down interfaces Line 8: I must agree with Edy; the text is not very clear.
I think what you mean is:
""" This change reports empty LLDP info for interfaces that are not UP.
Before this patch, a single operationally-down interface had caused the API level to fail, blocking information about properly-enabled interfaces. """
please correct my text if I misunderstood yours. Line 9: Reading LLDP information from an interface, which is not in state UP, Line 10: may result previously in an error on VDSM API level, even if the request Line 11: includes other interfaces, which are up. Line 12: Without the change, in the sequence interface down, enable LLDP and
vdsm-patches@lists.fedorahosted.org