Douglas Schilling Landgraf has posted comments on this change.
Change subject: BZ#772563 replace AC_PATH_PROG to AC_CHECK_PROG
......................................................................
Patch Set 2: (2 inline comments)
....................................................
Commit Message
Line 10: Currently, the AC_PATH_PROG doesn't check if the program really exists, for
example:
This is not entirely true, most of commands like, dd, nice, cat, blockdev, chown, cp,
etc.. are implicit required to mock systems like koji. As example, the groupinstall
buildsys-build (mock program) and all depedencies of this package, like coreutils etc..
So, it's not required to include BuildRequirements for each one of this basic
commands.
Another info, please check "Exception" session at:
http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRequires
Line 47: we can provide the correct path.
Let's consider a clean Fedora build system with a target as Fedora system, but if the
admin decides to install manually qemu-img at /usr/local/qemu/bin/qemu-img instead
/usr/bin/qemu-img our builder will break anyway with the current code. Of course, I
totally agree with you that if someone want to create a package to Fedora as target, they
should use a build system as Fedora but *a correct one*. However, currently we only
suppose/assume that. IMHO, this patch will just make us more safe.
Thanks
Douglas
--
To view, visit
http://gerrit.ovirt.org/1114
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I13b870c3e656dba2d840a341a5d6789a11036e40
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>