Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: vdsmd.init: Add service-is-managed in shutdown_conflicting_srv ......................................................................
vdsmd.init: Add service-is-managed in shutdown_conflicting_srv
We should not throw a stack trace if a service does not exist
Change-Id: I8916a73c446ea2f296b66f5fcf133b07c2d7a66c Signed-off-by: Douglas Schilling Landgraf dougsland@redhat.com --- M vdsm/vdsmd.init.in 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/97/19197/1
diff --git a/vdsm/vdsmd.init.in b/vdsm/vdsmd.init.in index b38791d..482d2ec 100755 --- a/vdsm/vdsmd.init.in +++ b/vdsm/vdsmd.init.in @@ -83,6 +83,7 @@ local srv
for srv in ${CONFLICTING_SERVICES}; do + "$VDSM_TOOL" service-is-managed "$srv" >/dev/null 2>&1 || continue "$VDSM_TOOL" service-disable "$srv" if "$VDSM_TOOL" service-status "$srv" > /dev/null 2>&1; then if [ "$srv" = "libvirt-guests" ]; then
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsmd.init: Add service-is-managed in shutdown_conflicting_srv ......................................................................
Patch Set 1: Verified+1
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsmd.init: Add service-is-managed in shutdown_conflicting_srv ......................................................................
Patch Set 2: Verified+1
Dan Kenigsberg has posted comments on this change.
Change subject: vdsmd.init: Add service-is-managed in shutdown_conflicting_srv ......................................................................
Patch Set 2: Code-Review+2
Federico Simoncelli has submitted this change and it was merged.
Change subject: vdsmd.init: Add service-is-managed in shutdown_conflicting_srv ......................................................................
vdsmd.init: Add service-is-managed in shutdown_conflicting_srv
We should not throw a stack trace if a service does not exist
Change-Id: I8916a73c446ea2f296b66f5fcf133b07c2d7a66c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1006842 Signed-off-by: Douglas Schilling Landgraf dougsland@redhat.com Reviewed-on: http://gerrit.ovirt.org/19197 Reviewed-by: Dan Kenigsberg danken@redhat.com --- M vdsm/vdsmd.init.in 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: Douglas Schilling Landgraf: Verified Dan Kenigsberg: Looks good to me, approved
vdsm-patches@lists.fedorahosted.org