Federico Simoncelli has uploaded a new change for review.
Change subject: [WIP] Upgrade a data domain on attachSD when required ......................................................................
[WIP] Upgrade a data domain on attachSD when required
RHBZ: 844367
Signed-off-by: Federico Simoncelli fsimonce@redhat.com Change-ID: I65dfd6dd339569fbaf276f3942a001c174423b1a --- M vdsm/storage/sp.py 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/44/7444/1
diff --git a/vdsm/storage/sp.py b/vdsm/storage/sp.py index da403d9..4d2e0cf 100644 --- a/vdsm/storage/sp.py +++ b/vdsm/storage/sp.py @@ -935,7 +935,7 @@
# If you remove this condition, remove it from # public_createStoragePool too. - if dom.isData() and domVers != mstVers: + if dom.isData() and domVers > mstVers: raise se.MixedSDVersionError(dom.sdUUID, domVers, self.masterDomain.sdUUID, mstVers)
-- To view, visit http://gerrit.ovirt.org/7444 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I65dfd6dd339569fbaf276f3942a001c174423b1a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP] Upgrade a data domain on attachSD when required ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/638/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/7444 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I65dfd6dd339569fbaf276f3942a001c174423b1a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Upgrade a data domain on attachSD when required ......................................................................
Patch Set 3:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/658/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/7444 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I65dfd6dd339569fbaf276f3942a001c174423b1a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Ayal Baron has posted comments on this change.
Change subject: Upgrade a data domain on attachSD when required ......................................................................
Patch Set 3: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/7444 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I65dfd6dd339569fbaf276f3942a001c174423b1a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Ayal Baron has posted comments on this change.
Change subject: Upgrade a data domain on attachSD when required ......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm/storage/sp.py Line 933: domVers = dom.getVersion() Line 934: mstVers = self.masterDomain.getVersion() Line 935: Line 936: # If you remove this condition, remove it from Line 937: # public_createStoragePool too. hsm.py contains this condition as well as the comment here indicates, why have you not fixed that as well? Line 938: if dom.isData() and domVers > mstVers: Line 939: raise se.MixedSDVersionError(dom.sdUUID, domVers, Line 940: self.masterDomain.sdUUID, mstVers) Line 941:
-- To view, visit http://gerrit.ovirt.org/7444 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I65dfd6dd339569fbaf276f3942a001c174423b1a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Federico Simoncelli has posted comments on this change.
Change subject: Upgrade a data domain on attachSD when required ......................................................................
Patch Set 3: (1 inline comment)
.................................................... File vdsm/storage/sp.py Line 933: domVers = dom.getVersion() Line 934: mstVers = self.masterDomain.getVersion() Line 935: Line 936: # If you remove this condition, remove it from Line 937: # public_createStoragePool too. Because I thought we didn't want to allow to create storage pools with mixed versions (but it might be handy). Now that I think of it we might hit that also if a storage domain didn't complete the upgrade and you want to create a new storage pool out of that (once detached). I'll check if that's a valid flow too. Line 938: if dom.isData() and domVers > mstVers: Line 939: raise se.MixedSDVersionError(dom.sdUUID, domVers, Line 940: self.masterDomain.sdUUID, mstVers) Line 941:
-- To view, visit http://gerrit.ovirt.org/7444 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I65dfd6dd339569fbaf276f3942a001c174423b1a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Upgrade a data domain on attachSD when required ......................................................................
Patch Set 4:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/733/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/7444 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I65dfd6dd339569fbaf276f3942a001c174423b1a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Ayal Baron has posted comments on this change.
Change subject: Upgrade a data domain on attachSD when required ......................................................................
Patch Set 4: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/7444 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I65dfd6dd339569fbaf276f3942a001c174423b1a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Federico Simoncelli has posted comments on this change.
Change subject: Upgrade a data domain on attachSD when required ......................................................................
Patch Set 4: Verified
-- To view, visit http://gerrit.ovirt.org/7444 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I65dfd6dd339569fbaf276f3942a001c174423b1a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Federico Simoncelli has posted comments on this change.
Change subject: Upgrade a data domain on attachSD when required ......................................................................
Patch Set 5: Verified
-- To view, visit http://gerrit.ovirt.org/7444 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I65dfd6dd339569fbaf276f3942a001c174423b1a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: Upgrade a data domain on attachSD when required ......................................................................
Patch Set 5: Looks good to me, approved
copying Ayal's former score.
-- To view, visit http://gerrit.ovirt.org/7444 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I65dfd6dd339569fbaf276f3942a001c174423b1a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Upgrade a data domain on attachSD when required ......................................................................
Upgrade a data domain on attachSD when required
It is now possible to attach a storage domain with a version that is older than the pool master domain. The upgrade will be started as soon as the domain will be activated.
Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=851518 Signed-off-by: Federico Simoncelli fsimonce@redhat.com Change-ID: I65dfd6dd339569fbaf276f3942a001c174423b1a --- M vdsm/storage/hsm.py M vdsm/storage/sp.py 2 files changed, 2 insertions(+), 2 deletions(-)
Approvals: Federico Simoncelli: Verified Dan Kenigsberg: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/7444 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I65dfd6dd339569fbaf276f3942a001c174423b1a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org