Moti Asayag has uploaded a new change for review.
Change subject: BZ#811807 Libvirt service engagement workaround ......................................................................
BZ#811807 Libvirt service engagement workaround
The patch intended to bypass a false report of libvirt service as started (when started with initctl). Instead of relying on initctl, vdsm awaits few seconds till the service is reported with its allocated process id (by 'pgrep').
Change-Id: I7f6fb1ef12caeca3a47adec206b653932026634f Signed-off-by: Moti Asayag masayag@redhat.com --- M vdsm/vdsmd.init.in 1 file changed, 14 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/61/7361/1
diff --git a/vdsm/vdsmd.init.in b/vdsm/vdsmd.init.in index d34b48d..fd09394 100755 --- a/vdsm/vdsmd.init.in +++ b/vdsm/vdsmd.init.in @@ -440,6 +440,20 @@ startout=`/sbin/initctl start libvirtd 2>&1` if [[ "$?" -eq 0 || "$startout" =~ .*already\ running.* ]]; then + + # Begin workaround + # Libvirt reports its service status as responsive despite its socket + # is not yet ready. Once issue fixed on libvirt, this WA shouls be removed. + for i in {1..20} + do + if pgrep libvirtd > /dev/null 2>&1; + then + return 0 + fi + sleep 1 + done + # End workaround + return 0 else echo "$startout" >&2
-- To view, visit http://gerrit.ovirt.org/7361 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I7f6fb1ef12caeca3a47adec206b653932026634f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Moti Asayag masayag@redhat.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: BZ#811807 Libvirt service engagement workaround ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/551/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/7361 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7f6fb1ef12caeca3a47adec206b653932026634f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Moti Asayag masayag@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#811807 Libvirt service engagement workaround ......................................................................
Patch Set 1: (3 inline comments)
arghh, that's ugly - but not your fault, and I have no better idea.
.................................................... File vdsm/vdsmd.init.in Line 442: then Line 443: Line 444: # Begin workaround Line 445: # Libvirt reports its service status as responsive despite its socket Line 446: # is not yet ready. Once issue fixed on libvirt, this WA shouls be removed. please keep new code in short lines. Line 447: for i in {1..20} Line 448: do Line 449: if pgrep libvirtd > /dev/null 2>&1; Line 450: then
Line 449: if pgrep libvirtd > /dev/null 2>&1; Line 450: then Line 451: return 0 Line 452: fi Line 453: sleep 1 do you have an estimate for a common waiting time? maybe we can `sleep 0.2` and improve latency? Line 454: done Line 455: # End workaround Line 456: Line 457: return 0
Line 450: then Line 451: return 0 Line 452: fi Line 453: sleep 1 Line 454: done I'd put this workaround into a separate function, and log an error if our 20 second timeout has expired with no libvirtd seen. Line 455: # End workaround Line 456: Line 457: return 0 Line 458: else
-- To view, visit http://gerrit.ovirt.org/7361 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7f6fb1ef12caeca3a47adec206b653932026634f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Moti Asayag masayag@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Antoni Segura Puimedon has posted comments on this change.
Change subject: BZ#811807 Libvirt service engagement workaround ......................................................................
Patch Set 1: (1 inline comment)
Small typo in comment.
.................................................... File vdsm/vdsmd.init.in Line 442: then Line 443: Line 444: # Begin workaround Line 445: # Libvirt reports its service status as responsive despite its socket Line 446: # is not yet ready. Once issue fixed on libvirt, this WA shouls be removed. s/shouls/should/ Line 447: for i in {1..20} Line 448: do Line 449: if pgrep libvirtd > /dev/null 2>&1; Line 450: then
-- To view, visit http://gerrit.ovirt.org/7361 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7f6fb1ef12caeca3a47adec206b653932026634f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Moti Asayag masayag@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Moti Asayag has posted comments on this change.
Change subject: BZ#811807 Libvirt service engagement workaround ......................................................................
Patch Set 1: (4 inline comments)
.................................................... File vdsm/vdsmd.init.in Line 442: then Line 443: Line 444: # Begin workaround Line 445: # Libvirt reports its service status as responsive despite its socket Line 446: # is not yet ready. Once issue fixed on libvirt, this WA shouls be removed. Done Line 447: for i in {1..20} Line 448: do Line 449: if pgrep libvirtd > /dev/null 2>&1; Line 450: then
Line 442: then Line 443: Line 444: # Begin workaround Line 445: # Libvirt reports its service status as responsive despite its socket Line 446: # is not yet ready. Once issue fixed on libvirt, this WA shouls be removed. Done Line 447: for i in {1..20} Line 448: do Line 449: if pgrep libvirtd > /dev/null 2>&1; Line 450: then
Line 449: if pgrep libvirtd > /dev/null 2>&1; Line 450: then Line 451: return 0 Line 452: fi Line 453: sleep 1 After several tests it takes a second or less for pgrep to report libvirt process. will modify it to 0.2, and will shorten the range for 10 seconds. Line 454: done Line 455: # End workaround Line 456: Line 457: return 0
Line 450: then Line 451: return 0 Line 452: fi Line 453: sleep 1 Line 454: done will issue a message to log if our 10 seconds timeout expired. Line 455: # End workaround Line 456: Line 457: return 0 Line 458: else
-- To view, visit http://gerrit.ovirt.org/7361 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7f6fb1ef12caeca3a47adec206b653932026634f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Moti Asayag masayag@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Moti Asayag masayag@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: BZ#811807 Libvirt service engagement workaround ......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/565/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/7361 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7f6fb1ef12caeca3a47adec206b653932026634f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Moti Asayag masayag@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Moti Asayag masayag@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#811807 Libvirt service engagement workaround ......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
.................................................... File vdsm/vdsmd.init.in Line 459: startout=`/sbin/initctl start libvirtd 2>&1` Line 460: if [[ "$?" -eq 0 || "$startout" =~ .*already\ running.* ]]; Line 461: then Line 462: Line 463: # Begin workaround frankly, I believe that a good name for the function would have made these comments needless. Line 464: await_libvirt_start Line 465: # End workaround Line 466: Line 467: return 0
-- To view, visit http://gerrit.ovirt.org/7361 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7f6fb1ef12caeca3a47adec206b653932026634f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Moti Asayag masayag@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Moti Asayag masayag@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Igor Lvovsky has posted comments on this change.
Change subject: BZ#811807 Libvirt service engagement workaround ......................................................................
Patch Set 2: (1 inline comment)
.................................................... File vdsm/vdsmd.init.in Line 422: Line 423: await_libvirt_start() { Line 424: # Libvirt reports its service status as responsive despite Line 425: # its socket is not yet ready. Once issue fixed on libvirt, Line 426: # this workaround should be removed. Is there BZ for this on Libvirt? Line 427: Line 428: for i in {1..50} Line 429: do Line 430: if pgrep libvirtd > /dev/null 2>&1;
-- To view, visit http://gerrit.ovirt.org/7361 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7f6fb1ef12caeca3a47adec206b653932026634f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Moti Asayag masayag@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Moti Asayag masayag@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Moti Asayag has posted comments on this change.
Change subject: Libvirt service engagement workaround ......................................................................
Patch Set 2: (2 inline comments)
.................................................... File vdsm/vdsmd.init.in Line 422: Line 423: await_libvirt_start() { Line 424: # Libvirt reports its service status as responsive despite Line 425: # its socket is not yet ready. Once issue fixed on libvirt, Line 426: # this workaround should be removed. saw several bugs around the 'upstart' but not a precise one as this one. Line 427: Line 428: for i in {1..50} Line 429: do Line 430: if pgrep libvirtd > /dev/null 2>&1;
Line 459: startout=`/sbin/initctl start libvirtd 2>&1` Line 460: if [[ "$?" -eq 0 || "$startout" =~ .*already\ running.* ]]; Line 461: then Line 462: Line 463: # Begin workaround Done Line 464: await_libvirt_start Line 465: # End workaround Line 466: Line 467: return 0
-- To view, visit http://gerrit.ovirt.org/7361 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7f6fb1ef12caeca3a47adec206b653932026634f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Moti Asayag masayag@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Moti Asayag masayag@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Libvirt service engagement workaround ......................................................................
Patch Set 3:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/675/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/7361 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7f6fb1ef12caeca3a47adec206b653932026634f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Moti Asayag masayag@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Moti Asayag masayag@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Moti Asayag has posted comments on this change.
Change subject: Libvirt service engagement workaround ......................................................................
Patch Set 3: Verified
-- To view, visit http://gerrit.ovirt.org/7361 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7f6fb1ef12caeca3a47adec206b653932026634f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Moti Asayag masayag@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Moti Asayag masayag@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: Libvirt service engagement workaround ......................................................................
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
sorry for not thinking about this before.
.................................................... File vdsm/vdsmd.init.in Line 433: fi Line 434: sleep 0.2 Line 435: done Line 436: Line 437: log_failure_msg "$prog: failed to connect to libvirt" I suppose we need to return failure here... Line 438: } Line 439: Line 440: start_libvirtd() { Line 441: local packaged target
Line 459: startout=`/sbin/initctl start libvirtd 2>&1` Line 460: if [[ "$?" -eq 0 || "$startout" =~ .*already\ running.* ]]; Line 461: then Line 462: await_libvirt_start_workaround Line 463: return 0 ... and here, with
return $? Line 464: else Line 465: echo "$startout" >&2 Line 466: return 1 Line 467: fi
-- To view, visit http://gerrit.ovirt.org/7361 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7f6fb1ef12caeca3a47adec206b653932026634f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Moti Asayag masayag@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Moti Asayag masayag@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Moti Asayag has posted comments on this change.
Change subject: Libvirt service engagement workaround ......................................................................
Patch Set 3: (1 inline comment)
.................................................... File vdsm/vdsmd.init.in Line 433: fi Line 434: sleep 0.2 Line 435: done Line 436: Line 437: log_failure_msg "$prog: failed to connect to libvirt" are we sure we want to fail on vdsm startup ? This modifies the previous behaviour of vsdm daemon start.
libvirt might start afterwards, but no custom filters will be defined on it (if this is the first vdsm upgrade which includes this feature). Line 438: } Line 439: Line 440: start_libvirtd() { Line 441: local packaged target
-- To view, visit http://gerrit.ovirt.org/7361 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7f6fb1ef12caeca3a47adec206b653932026634f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Moti Asayag masayag@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Moti Asayag masayag@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: Libvirt service engagement workaround ......................................................................
Patch Set 3: No score
(1 inline comment)
.................................................... File vdsm/vdsmd.init.in Line 433: fi Line 434: sleep 0.2 Line 435: done Line 436: Line 437: log_failure_msg "$prog: failed to connect to libvirt" understood. please have this function return the value, and continue to ignore it when it is called. Line 438: } Line 439: Line 440: start_libvirtd() { Line 441: local packaged target
-- To view, visit http://gerrit.ovirt.org/7361 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7f6fb1ef12caeca3a47adec206b653932026634f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Moti Asayag masayag@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Moti Asayag masayag@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Moti Asayag has posted comments on this change.
Change subject: Libvirt service engagement workaround ......................................................................
Patch Set 3: (1 inline comment)
.................................................... File vdsm/vdsmd.init.in Line 433: fi Line 434: sleep 0.2 Line 435: done Line 436: Line 437: log_failure_msg "$prog: failed to connect to libvirt" Done Line 438: } Line 439: Line 440: start_libvirtd() { Line 441: local packaged target
-- To view, visit http://gerrit.ovirt.org/7361 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7f6fb1ef12caeca3a47adec206b653932026634f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Moti Asayag masayag@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Moti Asayag masayag@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Libvirt service engagement workaround ......................................................................
Patch Set 4:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/685/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/7361 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7f6fb1ef12caeca3a47adec206b653932026634f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Moti Asayag masayag@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Moti Asayag masayag@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: Libvirt service engagement workaround ......................................................................
Patch Set 4: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/7361 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7f6fb1ef12caeca3a47adec206b653932026634f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Moti Asayag masayag@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Moti Asayag masayag@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Yaniv Bronhaim has posted comments on this change.
Change subject: Libvirt service engagement workaround ......................................................................
Patch Set 4: (1 inline comment)
.................................................... File vdsm/vdsmd.init.in Line 459: Line 460: startout=`/sbin/initctl start libvirtd 2>&1` Line 461: if [[ "$?" -eq 0 || "$startout" =~ .*already\ running.* ]]; Line 462: then Line 463: await_libvirt_start_workaround why don't you just put 5sec sleep here and add a condition that verifies if libvirtd is running (if pgrep libvirtd then; continue else return 1 fi) instead of this unnecessary loop .. it's not realtime process, we can wait 5 sec when we need to start libvirt (it rarely happens), and if libvirt is still not running you can do whatever you want (even ignore it and continue, as you do here :)) Line 464: return 0 Line 465: else Line 466: echo "$startout" >&2 Line 467: return 1
-- To view, visit http://gerrit.ovirt.org/7361 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7f6fb1ef12caeca3a47adec206b653932026634f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Moti Asayag masayag@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Moti Asayag masayag@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Moti Asayag has posted comments on this change.
Change subject: Libvirt service engagement workaround ......................................................................
Patch Set 4: (1 inline comment)
.................................................... File vdsm/vdsmd.init.in Line 459: Line 460: startout=`/sbin/initctl start libvirtd 2>&1` Line 461: if [[ "$?" -eq 0 || "$startout" =~ .*already\ running.* ]]; Line 462: then Line 463: await_libvirt_start_workaround you can review the history of this patch-set to see how it evolved to this point. The bottom line was to improve the latency. Line 464: return 0 Line 465: else Line 466: echo "$startout" >&2 Line 467: return 1
-- To view, visit http://gerrit.ovirt.org/7361 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7f6fb1ef12caeca3a47adec206b653932026634f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Moti Asayag masayag@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Moti Asayag masayag@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Yaniv Bronhaim has posted comments on this change.
Change subject: Libvirt service engagement workaround ......................................................................
Patch Set 4: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/7361 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7f6fb1ef12caeca3a47adec206b653932026634f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Moti Asayag masayag@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Moti Asayag masayag@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: Libvirt service engagement workaround ......................................................................
Patch Set 4: Verified
Copying yesterday's score.
-- To view, visit http://gerrit.ovirt.org/7361 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7f6fb1ef12caeca3a47adec206b653932026634f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Moti Asayag masayag@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Moti Asayag masayag@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Libvirt service engagement workaround ......................................................................
Libvirt service engagement workaround
The patch intended to bypass a false report of libvirt service as started (when started with initctl). Instead of relying on initctl, vdsm awaits few seconds till the service is reported with its allocated process id (by 'pgrep').
Change-Id: I7f6fb1ef12caeca3a47adec206b653932026634f Signed-off-by: Moti Asayag masayag@redhat.com --- M vdsm/vdsmd.init.in 1 file changed, 19 insertions(+), 0 deletions(-)
Approvals: Yaniv Bronhaim: Looks good to me, but someone else must approve Dan Kenigsberg: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/7361 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I7f6fb1ef12caeca3a47adec206b653932026634f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Moti Asayag masayag@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Moti Asayag masayag@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org