Dan Kenigsberg has posted comments on this change.
Change subject: vds_bootstrap: fix usage string ......................................................................
Patch Set 2: (2 inline comments)
Yotam, I've sent this patch just because you (duly) asked to fix the 'usage' string. I do not plan to rewrite vds_bootstrap - this is TEXTONLY.
.................................................... File vds_bootstrap/vds_bootstrap.py Line 909: -u {true|false} -- use rhev-m-deployed yum repo Line 910: -f -- override firewall rules by default ovirt rules. Line 911: obsolete options: Line 912: -n <netconsole_host:port> Line 913: -r <rev_num> well moving to optparse is something completely different. Line 914: """ Line 915: try: Line 916: rev_num = None Line 917: orgName = 'Red Hat Inc.'
Line 926: orgName = v Line 927: if o == "-t": Line 928: systime = v Line 929: if o == "-n": Line 930: # TODO: remove me as soon as possible (BZ#689726) we have to keep this, as long as RHEV-M sends it. this is why it is listed as obsolete. Line 931: pass Line 932: if o == "-u": Line 933: usevdcrepo = (v.upper() == 'TRUE') Line 934: elif o == '-f':
-- To view, visit http://gerrit.usersys.redhat.com/982 To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I8950764778dc61d04caeed4c74e792d52bba3378 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Yotam Oron yoron@redhat.com
vdsm-patches@lists.fedorahosted.org