Lee Yarwood has uploaded a new change for review.
Change subject: Correct spmprotect.sh to log the sdUUID to spm-lock.log. ......................................................................
Correct spmprotect.sh to log the sdUUID to spm-lock.log.
saferelease.acquire() actually calls spmprotect.sh with the sdUUID and not the spUUID.
Change-Id: I39a5499e8db28b0a54a186099877804601543b80 Signed-off-by: Lee Yarwood lyarwood@redhat.com --- M vdsm/storage/protect/spmprotect.sh 1 file changed, 11 insertions(+), 11 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/21/3821/1 -- To view, visit http://gerrit.ovirt.org/3821 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I39a5499e8db28b0a54a186099877804601543b80 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood lyarwood@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Correct spmprotect.sh to log the sdUUID to spm-lock.log. ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
boy, this means that now you own most of the lines, according to `git blame`
-- To view, visit http://gerrit.ovirt.org/3821 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I39a5499e8db28b0a54a186099877804601543b80 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood lyarwood@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com
Lee Yarwood has posted comments on this change.
Change subject: Correct spmprotect.sh to log the sdUUID to spm-lock.log. ......................................................................
Patch Set 1:
I'd be happy to leave this correction to the original authors if you'd like to keep git blame clean Dan.
-- To view, visit http://gerrit.ovirt.org/3821 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I39a5499e8db28b0a54a186099877804601543b80 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood lyarwood@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Lee Yarwood lyarwood@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Correct spmprotect.sh to log the sdUUID to spm-lock.log. ......................................................................
Patch Set 1:
note to self: never try to joke in Gerrit. it does not come through.
-- To view, visit http://gerrit.ovirt.org/3821 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I39a5499e8db28b0a54a186099877804601543b80 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood lyarwood@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Lee Yarwood lyarwood@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Lee Yarwood has posted comments on this change.
Change subject: Correct spmprotect.sh to log the sdUUID to spm-lock.log. ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
Apologies I've been out for a while. Bumping this again, hopefully there are no objections?
-- To view, visit http://gerrit.ovirt.org/3821 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I39a5499e8db28b0a54a186099877804601543b80 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood lyarwood@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Lee Yarwood lyarwood@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Ayal Baron has posted comments on this change.
Change subject: Correct spmprotect.sh to log the sdUUID to spm-lock.log. ......................................................................
Patch Set 1:
what about a test
-- To view, visit http://gerrit.ovirt.org/3821 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I39a5499e8db28b0a54a186099877804601543b80 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood lyarwood@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Lee Yarwood lyarwood@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Shu Ming has posted comments on this change.
Change subject: Correct spmprotect.sh to log the sdUUID to spm-lock.log. ......................................................................
Patch Set 1: Verified; Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/3821 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I39a5499e8db28b0a54a186099877804601543b80 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood lyarwood@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Lee Yarwood lyarwood@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com
Lee Yarwood has posted comments on this change.
Change subject: Correct spmprotect.sh to log the sdUUID to spm-lock.log. ......................................................................
Patch Set 1:
Ayal, do you mean a generic test for spmprotect.sh or just in the context of this change (that only changes the logging...)?
If it's the former I can follow up in an additional commit with something.
Thanks,
Lee
-- To view, visit http://gerrit.ovirt.org/3821 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I39a5499e8db28b0a54a186099877804601543b80 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood lyarwood@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Lee Yarwood lyarwood@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: Correct spmprotect.sh to log the sdUUID to spm-lock.log. ......................................................................
Patch Set 1:
yes, it would be great if you add a generick spmprotect test.
-- To view, visit http://gerrit.ovirt.org/3821 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I39a5499e8db28b0a54a186099877804601543b80 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood lyarwood@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Lee Yarwood lyarwood@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: Correct spmprotect.sh to log the sdUUID to spm-lock.log. ......................................................................
Patch Set 1: Looks good to me, approved
I'd be waiting for a unit test in a different patch.
-- To view, visit http://gerrit.ovirt.org/3821 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I39a5499e8db28b0a54a186099877804601543b80 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood lyarwood@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Lee Yarwood lyarwood@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Correct spmprotect.sh to log the sdUUID to spm-lock.log. ......................................................................
Correct spmprotect.sh to log the sdUUID to spm-lock.log.
saferelease.acquire() actually calls spmprotect.sh with the sdUUID and not the spUUID.
Change-Id: I39a5499e8db28b0a54a186099877804601543b80 Signed-off-by: Lee Yarwood lyarwood@redhat.com --- M vdsm/storage/protect/spmprotect.sh 1 file changed, 11 insertions(+), 11 deletions(-)
Approvals: Lee Yarwood: Looks good to me, but someone else must approve Shu Ming: Verified; Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/3821 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I39a5499e8db28b0a54a186099877804601543b80 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood lyarwood@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Lee Yarwood lyarwood@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com
vdsm-patches@lists.fedorahosted.org