From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: virt: Use vmxml DOM helpers in vmdevices/common.py
......................................................................
Patch Set 10: Code-Review-1
sorry for blindly rebasing - it is a real issue with the tests, not a CI glitch.
11:13:19 ERROR: test_sriov_vm (devices.parsing.complex_vm_tests.TestSRiovXmlParsing)
11:13:19 ----------------------------------------------------------------------
11:13:19 Traceback (most recent call last):
11:13:19 File
"/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/tests/devices/parsing/complex_vm_tests.py",
line 95, in test_sriov_vm
11:13:19 vm._getUnderlyingVmDevicesInfo()
11:13:19 File
"/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/vdsm/virt/vm.py",
line 1636, in _getUnderlyingVmDevicesInfo
11:13:19 vmdevices.common.update_device_info(self, self._devices)
11:13:19 File
"/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/vdsm/virt/vmdevices/common.py",
line 90, in update_device_info
11:13:19 _update_unknown_device_info(vm)
11:13:19 File
"/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/vdsm/virt/vmdevices/common.py",
line 52, in _update_unknown_device_info
11:13:19 alias = vmxml.attr(x, 'alias', 'name')
11:13:19 TypeError: attr() takes exactly 2 arguments (3 given)
11:13:19 -------------------- >> begin captured logging <<
--------------------
11:13:19 2016-11-13 11:13:19,333 DEBUG (MainThread) [virt.vm] (vmId='TESTING')
Ignoring param (target, 262144) in Balloon (core:52)
11:13:19 --------------------- >> end captured logging <<
---------------------
11:13:19
11:13:19 ======================================================================
11:13:19 ERROR: test_complex_vm
(devices.parsing.complex_vm_tests.TestVmDevicesXmlParsing)
11:13:19 ----------------------------------------------------------------------
11:13:19 Traceback (most recent call last):
11:13:19 File
"/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/tests/devices/parsing/complex_vm_tests.py",
line 59, in test_complex_vm
11:13:19 vm._getUnderlyingVmDevicesInfo()
11:13:19 File
"/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/vdsm/virt/vm.py",
line 1636, in _getUnderlyingVmDevicesInfo
11:13:19 vmdevices.common.update_device_info(self, self._devices)
11:13:19 File
"/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/vdsm/virt/vmdevices/common.py",
line 90, in update_device_info
11:13:19 _update_unknown_device_info(vm)
11:13:19 File
"/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/vdsm/virt/vmdevices/common.py",
line 52, in _update_unknown_device_info
11:13:19 alias = vmxml.attr(x, 'alias', 'name')
11:13:19 TypeError: attr() takes exactly 2 arguments (3 given)
11:13:19 -------------------- >> begin captured logging <<
--------------------
11:13:19 2016-11-13 11:13:19,358 DEBUG (MainThread) [virt.vm] (vmId='TESTING')
Ignoring param (target, 262144) in Balloon (core:52)
11:13:19 2016-11-13 11:13:19,386 DEBUG (MainThread) [virt.vm] (vmId='TESTING')
Looking for drive with attributes {'name': u'hdc', 'bootOrder':
'', 'boot': [], 'readonly': True, 'address':
{u'bus': u'1', u'controller': u'0', u'type':
u'drive', u'target': u'0', u'unit': u'0'},
'path': '', 'type': u'cdrom'} (storage:105)
11:13:19 2016-11-13 11:13:19,387 WARNING (MainThread) [virt.vm] (vmId='TESTING')
Found unknown drive: {'alias': u'cdrom1', 'readonly':
'True', 'iface': 'ide', 'name': u'hdc',
'address': {u'bus': u'1', u'controller': u'0',
u'type': u'drive', u'target': u'0', u'unit':
u'0'}, 'device': u'cdrom', 'path': '',
'type': 'disk'} (storage:158)
--
To view, visit
https://gerrit.ovirt.org/56097
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2941f79b65f80152255c27260942efc38f8f8ceb
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No