Wenyi Gao has posted comments on this change.
Change subject: Remove the effect of other parameters on configure_sysctl in vdsmd.init
......................................................................
Patch Set 3: No score
Thanks for Dan's and Mark's comments.
Yes, the "modprobe bridge" is done, the problem goes away.
Also I tested it on fresh Fedora16, the interface virtbr0 can be created successfully by
libvirt, so there is no error in
sysctl -q -p /etc/sysctl.conf
Obviously, the problem will happen if libvirt doesn't load module "bridge".
Dan, do you think it is necessary to add "modprobe bridge" in
load_needed_modules to to make sure the module is loaded before configuring sysctl?
--
To view, visit
http://gerrit.ovirt.org/4865
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d9f917a4abfb6952fb9fdd6a9c0e12751ecd061
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>