Allon Mureinik has posted comments on this change.
Change subject: Separate the Volume.share implementation
......................................................................
Patch Set 22: Looks good to me, but someone else must approve
(1 inline comment)
see inline suggestion
....................................................
File vdsm/storage/fileVolume.py
Line 298: self.oop.os.link(self.getVolumePath(), dstVolPath)
You have this pattern several times:
self.oop.fileUtils.safeUnlink(destPath)
self.oop.os.link(src, destPath)
how about wrapping it in a method? e.g., self.forceLink(src, dst)?
--
To view, visit
http://gerrit.ovirt.org/3737
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I965b56dc98fe2d6db3ef6f3d7efe2a7b9791b555
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>