Nir Soffer has posted comments on this change.
Change subject: vdsm: Missing hostId parameter on reconstructMaster verb
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/29510/1/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:
Line 5234: # @StoragePool.reconstructMaster:
Line 5235: #
Line 5236: # Recover a Storage Pool by reconstructing its Storage Domains.
Line 5237: #
Line 5238: # @storagepoolID: The UUID of the Storage Pool
As I can see in API.py storagepoolID is constructor argument which is
still
You are correct - the API code is horrible.
Line 5239: #
Line 5240: # @hostId: Host Id used by San lock.
Line 5241: #
Line 5242: # @name: A human-readable name for the Storage Pool
--
To view, visit
http://gerrit.ovirt.org/29510
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0695a21601b8f0765bc24c3cf273f1ba161a40a9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes