Federico Simoncelli has uploaded a new change for review.
Change subject: BZ#826022 Disable the sanlock volume leases ......................................................................
BZ#826022 Disable the sanlock volume leases
Signed-off-by: Federico Simoncelli fsimonce@redhat.com Change-Id: Ib799ce25cb4c8a363d4021d8a1c63c7925d33855 --- M vdsm/libvirtvm.py 1 file changed, 15 insertions(+), 10 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/72/4872/1 -- To view, visit http://gerrit.ovirt.org/4872 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Ib799ce25cb4c8a363d4021d8a1c63c7925d33855 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com
Eduardo has posted comments on this change.
Change subject: BZ#826022 Disable the sanlock volume leases ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm/libvirtvm.py Line 1208: # domxml._devices.appendChild(leaseElem) Why the leaseElem is not genereated by the "drive" entity?
You are not using sanlock for disks here. Is necessary to maintain this code?
-- To view, visit http://gerrit.ovirt.org/4872 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib799ce25cb4c8a363d4021d8a1c63c7925d33855 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com
Allon Mureinik has posted comments on this change.
Change subject: BZ#826022 Disable the sanlock volume leases ......................................................................
Patch Set 1: (1 inline comment)
.................................................... File vdsm/libvirtvm.py Line 1193: Is this an issue with SANLock or with VDSM's interaction/usage of SANLock?
I'm not a fan of leaving commented out blocks of code:
If this is a SANlock issue, perhaps we should have a configuration value of which version of SANLock supports this (with the value set to 999 or something ridiculous like that)?
-- To view, visit http://gerrit.ovirt.org/4872 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib799ce25cb4c8a363d4021d8a1c63c7925d33855 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Allon Mureinik amureini@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com
Allon Mureinik has posted comments on this change.
Change subject: BZ#826022 Disable the sanlock volume leases ......................................................................
Patch Set 2: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/4872 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib799ce25cb4c8a363d4021d8a1c63c7925d33855 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Allon Mureinik amureini@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com
Federico Simoncelli has abandoned this change.
Change subject: BZ#826022 Disable the sanlock volume leases ......................................................................
Patch Set 2: Abandoned
This issue will be fixed by sanlock.
-- To view, visit http://gerrit.ovirt.org/4872 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: Ib799ce25cb4c8a363d4021d8a1c63c7925d33855 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Allon Mureinik amureini@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com
vdsm-patches@lists.fedorahosted.org