Federico Simoncelli has uploaded a new change for review.
Change subject: tool: skip sebool entry setup when missing ......................................................................
tool: skip sebool entry setup when missing
The sebool variable we want to configure might not be present on all platforms.
Change-Id: Ib2379e57a33aa280504557a2ea797fe3b4ec8c1a Signed-off-by: Federico Simoncelli fsimonce@redhat.com --- M vdsm-tool/seboolsetup.py 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/27/9827/1
diff --git a/vdsm-tool/seboolsetup.py b/vdsm-tool/seboolsetup.py index 437da68..3db52eb 100644 --- a/vdsm-tool/seboolsetup.py +++ b/vdsm-tool/seboolsetup.py @@ -42,6 +42,11 @@ sebool_obj.start()
for sebool_variable in VDSM_SEBOOL_LIST: + # The sebool_variable we want to configure might not be + # present on all platforms. + if sebool_variable not in sebool_status + continue + if status and not all(sebool_status[sebool_variable]): sebool_obj.modify(sebool_variable, SEBOOL_ENABLED)
-- To view, visit http://gerrit.ovirt.org/9827 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Ib2379e57a33aa280504557a2ea797fe3b4ec8c1a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tool: skip sebool entry setup when missing ......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/314/ (2/2)
-- To view, visit http://gerrit.ovirt.org/9827 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib2379e57a33aa280504557a2ea797fe3b4ec8c1a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tool: skip sebool entry setup when missing ......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/280/ (1/2)
-- To view, visit http://gerrit.ovirt.org/9827 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib2379e57a33aa280504557a2ea797fe3b4ec8c1a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tool: skip sebool entry setup when missing ......................................................................
Patch Set 1: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/280/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/314/ : FAILURE
-- To view, visit http://gerrit.ovirt.org/9827 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib2379e57a33aa280504557a2ea797fe3b4ec8c1a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Igor Lvovsky has posted comments on this change.
Change subject: tool: skip sebool entry setup when missing ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm-tool/seboolsetup.py Line 43: Line 44: for sebool_variable in VDSM_SEBOOL_LIST: Line 45: # The sebool_variable we want to configure might not be Line 46: # present on all platforms. Line 47: if sebool_variable not in sebool_status looks like you missed ':' Line 48: continue Line 49: Line 50: if status and not all(sebool_status[sebool_variable]): Line 51: sebool_obj.modify(sebool_variable, SEBOOL_ENABLED)
-- To view, visit http://gerrit.ovirt.org/9827 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib2379e57a33aa280504557a2ea797fe3b4ec8c1a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tool: skip sebool entry setup when missing ......................................................................
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/315/ (2/2)
-- To view, visit http://gerrit.ovirt.org/9827 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib2379e57a33aa280504557a2ea797fe3b4ec8c1a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tool: skip sebool entry setup when missing ......................................................................
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/281/ (1/2)
-- To view, visit http://gerrit.ovirt.org/9827 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib2379e57a33aa280504557a2ea797fe3b4ec8c1a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tool: skip sebool entry setup when missing ......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/281/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/315/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/9827 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib2379e57a33aa280504557a2ea797fe3b4ec8c1a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: tool: skip sebool entry setup when missing ......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
.................................................... Commit Message Line 5: CommitDate: 2012-12-10 11:26:33 -0500 Line 6: Line 7: tool: skip sebool entry setup when missing Line 8: Line 9: The sebool variable we want to configure might not be present on all would you provide more context? which boolean/platform are you protecting? shouldn't we just require a newer policy? Line 10: platforms. Line 11: Line 12: Change-Id: Ib2379e57a33aa280504557a2ea797fe3b4ec8c1a
-- To view, visit http://gerrit.ovirt.org/9827 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib2379e57a33aa280504557a2ea797fe3b4ec8c1a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Federico Simoncelli has abandoned this change.
Change subject: tool: skip sebool entry setup when missing ......................................................................
Patch Set 2: Abandoned
-- To view, visit http://gerrit.ovirt.org/9827 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: Ib2379e57a33aa280504557a2ea797fe3b4ec8c1a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org